Skip to content

fix: respect npm_config_registry for update checks #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Will-hxw wants to merge 2 commits into from
+11 −1
Closed

fix: respect npm_config_registry for update checks #1961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d91b00
fix: respect npm_config_registry for update checks
Will-hxw Apr 27, 2026
5462a96
fix: use npm config get registry to support direct CLI invocation
Will-hxw Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/bin/check-latest-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* SPDX-License-Identifier: Apache-2.0
*/

import {execSync} from 'node:child_process';
import fs from 'node:fs/promises';
import path from 'node:path';
import process from 'node:process';
Expand All @@ -12,8 +13,17 @@ const cachePath = process.argv[2];

if (cachePath) {
try {
let registry;
try {
registry = execSync('npm config get registry', {
encoding: 'utf8',
}).trim().replace(/\/$/, '');
} catch {
// npm not on PATH, fall back to default
}
registry ||= 'https://registry.npmjs.org';
const response = await fetch(
'https://registry.npmjs.org/chrome-devtools-mcp/latest',
`${registry}/chrome-devtools-mcp/latest`,
);
const data = response.ok ? await response.json() : null;

Expand Down