fix: restrict URL schemes in page navigation to http/https#972
Closed
AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
Closed
fix: restrict URL schemes in page navigation to http/https#972AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
AI-Reviewer-QS wants to merge 1 commit intoChromeDevTools:mainfrom
Conversation
The new_page and navigate_page tools pass user-provided URLs directly to page.goto() without validating the URL scheme. This allows navigating to potentially dangerous schemes like file://, chrome://, or data: URLs. Add URL scheme validation that restricts navigation to http:, https:, and about: schemes.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_pageandnavigate_pagetools pass user-provided URLs directly topage.goto()without validating the URL schemefile://,chrome://, ordata:URLs which could expose local files or internal browser statehttp:,https:, andabout:schemesTest plan
http://andhttps://URLs work normally innew_pagehttp://andhttps://URLs work normally innavigate_pagefile://URLs are rejected with clear error messagechrome://URLs are rejecteddata:URLs are rejectedabout:blankstill works