Skip to content

fix: restrict URL schemes in page navigation to http/https #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AI-Reviewer-QS wants to merge 1 commit into from
Closed

fix: restrict URL schemes in page navigation to http/https #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/tools/pages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,24 @@ import {zod} from '../third_party/index.js';
import {ToolCategory} from './categories.js';
import {CLOSE_PAGE_ERROR, defineTool, timeoutSchema} from './ToolDefinition.js';

const ALLOWED_URL_SCHEMES = ['http:', 'https:', 'about:'];

function validateUrlScheme(url: string): void {
let parsed: URL;
try {
parsed = new URL(url);
} catch {
// If it can't be parsed as a URL, let the browser handle it
// (e.g. relative paths or malformed input)
return;
}
if (!ALLOWED_URL_SCHEMES.includes(parsed.protocol)) {
throw new Error(
`URL scheme "${parsed.protocol}" is not allowed. Allowed schemes: ${ALLOWED_URL_SCHEMES.join(', ')}`,
);
}
}

export const listPages = defineTool({
name: 'list_pages',
description: `Get a list of pages open in the browser.`,
Expand Down Expand Up @@ -96,6 +114,7 @@ export const newPage = defineTool({
...timeoutSchema,
},
handler: async (request, response, context) => {
validateUrlScheme(request.params.url);
const page = await context.newPage(request.params.background);

await context.waitForEventsAfterAction(
Expand Down Expand Up @@ -193,6 +212,7 @@ export const navigatePage = defineTool({
'A URL is required for navigation of type=url.',
);
}
validateUrlScheme(request.params.url);
try {
await page.goto(request.params.url, options);
response.appendResponseLine(
Expand Down