You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.
The reviewed changes appear safe to merge; no new actionable issue was found.
Summary
Adds scheduled commands for PostgreSQL, MySQL, MariaDB, MongoDB, Redis, and LibSQL.
Database service pages let operators create and manage scheduled commands.
Scheduled commands run in database containers and keep their run logs.
Deleting a database or project also clears its scheduled jobs.
Both earlier, unnumbered findings are addressed in the current code. No new actionable issue was found in the changes since the last review. Runtime tests were not run.
The page uses permissions?.schedule.read but never declares permissions, so it would also crash at runtime with ReferenceError: permissions is not defined. Add the same query the other DB pages use:
The zod-inferred input isn't assignable to Partial<Schedule> when passed to isValidDatabaseScheduleTarget / getDatabaseScheduleId. The existing createSchedule / updateSchedule already cast this same zod type before handing it to drizzle.
Please type both helpers to accept only the fields they read (scheduleType, the DB id columns, applicationId, composeId, serverId, organizationId), or cast at the call site like the existing code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Add scheduled jobs for databases
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #5388


Confidence Score: 5/5
The reviewed changes appear safe to merge; no new actionable issue was found.Summary
Adds scheduled commands for PostgreSQL, MySQL, MariaDB, MongoDB, Redis, and LibSQL.
Both earlier, unnumbered findings are addressed in the current code. No new actionable issue was found in the changes since the last review. Runtime tests were not run.
Reviews (2) · Last reviewed commit: "fix: verify cloud scheduler cancellation..." · Reviewed by Greptile