Repository navigation
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Kwon Yeseol <172019512+yeseorizi@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix DVL-to-ROS translation and callback lifetime issues reproduced on current
main(0d19c3f).TwistWithCovarianceis 6×6. Map values into the top-left linear block, rather than copying them contiguously into the first nine ROS entries. Apply the same mapping to individual beams.Reproduction and validation
The baseline failed the covariance-layout and host-signal-handler regressions. Tests also cover empty/oversized covariance, unconfigured and shut-down contexts, and 30 create/destroy cycles while a transport publisher is active (with a connection assertion).
pre-commitchecks passed.colcon build --packages-select posim_ros_gz_plugins --cmake-args -DBUILD_TESTING=ON ctest --test-dir build/posim_ros_gz_plugins --output-on-failure \ -R '^test_dvl_bridge$' --repeat until-fail:10Scope / limitations
Tested in Ubuntu 26.04 ARM64 Docker on an Apple Silicon Mac, ROS 2 Lyrical / Gazebo Jetty 10.5.0. The fix concerns translation and lifecycle, not changes to the acoustic DVL model or a claim of physical accuracy. No ASan/TSan, native Linux host or real-GPU validation is claimed. The separate
ros_gz_bridgeshutdown issue is not fixed by this PR.Checklist
pre-commit.colcon testis clean. The earlier full audit also reports pre-existing ament cpplint/uncrustify/copyright failures; no tests were disabled here.Assisted-by: OpenAI Codex (implementation, tests and PR preparation).