Skip to content

fix(assets-controller): re-run snap discovery on snap install#8862

Merged
salimtb merged 2 commits into
mainfrom
fix/snap-data-source-snap-installed-rediscovery
May 20, 2026
Merged

fix(assets-controller): re-run snap discovery on snap install#8862
salimtb merged 2 commits into
mainfrom
fix/snap-data-source-snap-installed-rediscovery

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented May 20, 2026

Subscribe to SnapController:snapInstalled so that keyring snap chain discovery is re-triggered whenever a new snap is installed. This ensures snap-backed chains (Bitcoin, Solana, Tron, etc.) appear in activeChains immediately after install without waiting for a permission state change.

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds a new required messenger event (SnapController:snapInstalled) for SnapDataSource, which is a breaking integration change for hosts using restricted messengers; functional logic change is small but could prevent snap chain discovery if not wired.

Overview
Ensures snap-backed chains become available immediately after installing a new snap by having SnapDataSource subscribe to SnapController:snapInstalled and re-run keyring snap discovery.

Updates messenger typing so SnapControllerSnapInstalledEvent is included in SnapDataSourceAllowedEvents, and documents the resulting breaking requirement in the assets-controller changelog for hosts that restrict allowed events.

Reviewed by Cursor Bugbot for commit bf74ff7. Bugbot is set up for automated code reviews on this repo. Configure here.

Subscribe to `SnapController:snapInstalled` so that keyring snap chain
discovery is re-triggered whenever a new snap is installed. This ensures
snap-backed chains (Bitcoin, Solana, Tron, etc.) appear in `activeChains`
immediately after install without waiting for a permission state change.
@salimtb salimtb force-pushed the fix/snap-data-source-snap-installed-rediscovery branch from 1192c06 to c512559 Compare May 20, 2026 14:30
@salimtb salimtb marked this pull request as ready for review May 20, 2026 14:37
@salimtb salimtb requested review from a team as code owners May 20, 2026 14:37
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bf74ff7. Configure here.

Comment thread packages/assets-controller/src/data-sources/SnapDataSource.ts
@salimtb salimtb temporarily deployed to default-branch May 20, 2026 14:40 — with GitHub Actions Inactive
@salimtb salimtb added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 7389a3c May 20, 2026
374 checks passed
@salimtb salimtb deleted the fix/snap-data-source-snap-installed-rediscovery branch May 20, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants