Skip to content

fix(assets-controller): re-run snap discovery on snap install #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salimtb merged 2 commits into from
May 20, 2026
+8 −1
Merged

fix(assets-controller): re-run snap discovery on snap install #8862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c512559
fix(assets-controller): re-run snap discovery on snap install
salimtb May 20, 2026
bf74ff7
fix: fix changelog
salimtb May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/assets-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- **BREAKING:** **SnapDataSource:** `SnapControllerSnapInstalledEvent` has been added to `SnapDataSourceAllowedEvents`. Hosts that restrict which events flow through the `AssetsController` messenger must now also delegate `SnapController:snapInstalled`; failing to do so will prevent snap chain re-discovery after install. Re-run keyring snap discovery when a new snap is installed so that snap-backed chains (Bitcoin, Solana, Tron, etc.) become available immediately after install ([#8862](https://github.com/MetaMask/core/pull/8862))
- Non-EVM assets with a `slip44` asset namespace (e.g. Bitcoin, Solana native, TRON) are now correctly typed as `native` instead of `erc20` in `assetsInfo` ([#8811](https://github.com/MetaMask/core/pull/8811))
- Solana SPL tokens (CAIP-19 `solana:.../token:<address>`) are now correctly typed as `spl` instead of `erc20` in `assetsInfo` ([#8811](https://github.com/MetaMask/core/pull/8811))

Expand Down
8 changes: 7 additions & 1 deletion packages/assets-controller/src/data-sources/SnapDataSource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {
import type {
SnapControllerGetRunnableSnapsAction,
SnapControllerHandleRequestAction,
SnapControllerSnapInstalledEvent,
} from '@metamask/snaps-controllers';
import type { Snap, SnapId } from '@metamask/snaps-sdk';
import { HandlerType, SnapCaveatType } from '@metamask/snaps-utils';
Expand Down Expand Up @@ -144,7 +145,8 @@ const defaultSnapState: SnapDataSourceState = {
*/
export type SnapDataSourceAllowedEvents =
| AccountsControllerAccountBalancesUpdatedEvent
| PermissionControllerStateChange;
| PermissionControllerStateChange
| SnapControllerSnapInstalledEvent;

export type SnapDataSourceAllowedActions =
| SnapControllerGetRunnableSnapsAction
Expand Down Expand Up @@ -254,6 +256,10 @@ export class SnapDataSource extends AbstractDataSource<
'PermissionController:stateChange',
this.#handlePermissionStateChangeBound,
);
// Rediscover keyring snaps when any snap gets installed
messenger.subscribe('SnapController:snapInstalled', () => {
this.#discoverKeyringSnaps();
});
Comment thread
salimtb marked this conversation as resolved.
}

/**
Expand Down
Loading