Repository navigation
fix(general/ci): match the inactive PR reminder on its author and message - #176
Conversation
…sage Any bot comment containing "inactive for" counted as a reminder, so another bot's wording could suppress a due one. Match comments from github-actions[bot] with the reminder's own message, which still recognises reminders posted before this change. Follow-up to #169 review feedback. Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
Description
Trivial follow-up to #169 (issue #168), from CodeRabbit's review comment that was still open when #169 merged.
isRemindertreated any bot comment containing "inactive for" as this workflow's reminder, so another bot using that phrase after a PR's last activity would suppress a reminder that was due. It now requires a comment fromgithub-actions[bot]matching the reminder's own message,/this PR has been inactive for \d+ days\./. Reminders posted before this change use the same text, so they still match.The same change is in NVIDIA/nodewright#927; the two copies stay identical apart from the fork guard.
How this was verified
actionlinton the workflow: clean.make license-check: clean.createCommentstubbed,mainagainst this branch:mainskips both; this branch reminds both. Every other case (bot-only activity, bot force-push, bot thread reply skipped; human review, thread reply, force-push, newer commit reminded) gives the same result on both.Tested on
n/a: CI workflow change only.
Checklist
git commit -s -S.