Skip to content

fix(general/ci): match the inactive PR reminder on its author and message - #176

Merged
lockwobr merged 3 commits into
mainfrom
fix/reminder-match
Oct 30, 2026
Merged

lockwobr merged 3 commits into
mainfrom
fix/reminder-match

Conversation

@lockwobr

@lockwobr lockwobr commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Trivial follow-up to #169 (issue #168), from CodeRabbit's review comment that was still open when #169 merged.

isReminder treated any bot comment containing "inactive for" as this workflow's reminder, so another bot using that phrase after a PR's last activity would suppress a reminder that was due. It now requires a comment from github-actions[bot] matching the reminder's own message, /this PR has been inactive for \d+ days\./. Reminders posted before this change use the same text, so they still match.

The same change is in NVIDIA/nodewright#927; the two copies stay identical apart from the fork guard.

How this was verified

  • actionlint on the workflow: clean. make license-check: clean.
  • Dry run of the extracted script in Node with createComment stubbed, main against this branch:
    • Synthetic PRs at day 8: a CodeRabbit comment saying "inactive for" and one with the exact reminder text, each after the last activity on a PR that was never reminded. main skips both; this branch reminds both. Every other case (bot-only activity, bot force-push, bot thread reply skipped; human review, thread reply, force-push, newer commit reminded) gives the same result on both.
    • Real fix(nvidia-setup): avoid mixed array echo arguments #154 timeline cut at 2026-10-29 07:00 UTC: this branch posts the "inactive for 12 days" reminder that the live workflow actually sent that morning. With the full timeline at 2026-11-06 it treats that reminder as the reminder for the current stall and posts nothing new.

Tested on

n/a: CI workflow change only.

Checklist

  • I am familiar with the Contributing Guidelines.
  • This PR closes an issue that is assigned to me, or it is one of the exceptions that needs none (a trivial change, a Dependabot update, or a security fix coordinated through SECURITY.md).
  • My commits are signed off per the DCO and cryptographically signed: git commit -s -S.
  • I ran the checks that apply to this change locally and recorded the result above.
  • If this changes a package, the "Tested on" section above says what it ran on, or says plainly that it has not run on hardware.
  • New or existing tests cover these changes. (No test harness exists for workflow scripts; the dry run above stands in.)
  • The documentation is up to date with these changes.
  • If an AI tool wrote a meaningful part of this change, I have said so above, and I can explain and defend every line of it. Written with Claude Code.

…sage

Any bot comment containing "inactive for" counted as a reminder, so
another bot's wording could suppress a due one. Match comments from
github-actions[bot] with the reminder's own message, which still
recognises reminders posted before this change.

Follow-up to #169 review feedback.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between b451062 and 01cd5ce.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
Walkthrough

The inactive PR reminder detector now requires a commented event, the exact actor login github-actions[bot], and a comment body matching the full reminder sentence with a numeric day count.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: component/ci

Suggested reviewers: ayuskauskas

Merge Risk: Minimal · previous review 4321d

The detector recognizes the workflow’s generated reminder and excludes unrelated authors; the change is ready to merge.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: matching inactive PR reminders by both author and message.
Description check Passed The description directly explains the workflow change, its purpose, verification steps, and testing limitations.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lockwobr
lockwobr enabled auto-merge (squash) October 30, 2026 20:38
@lockwobr
lockwobr disabled auto-merge October 30, 2026 22:27
@lockwobr
lockwobr enabled auto-merge (squash) October 30, 2026 22:58
@lockwobr
lockwobr merged commit 1e1a336 into main Oct 30, 2026
13 checks passed
@lockwobr
lockwobr deleted the fix/reminder-match branch October 30, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants