Repository navigation
fix(ci): match the inactive PR reminder on its author and message - #927
Conversation
Any bot comment containing "inactive for" counted as a reminder, so another bot's wording could suppress a due one. Match comments from github-actions[bot] with the reminder's own message, which still recognises reminders posted before this change. Follow-up to #893 review feedback. Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
Description
Trivial follow-up to #893 (issue #892), porting NVIDIA/nodewright-packages#176 so the two copies of the workflow stay identical apart from the fork guard.
isRemindertreated any bot comment containing "inactive for" as this workflow's reminder, so another bot using that phrase after a PR's last activity would suppress a reminder that was due. It now requires a comment fromgithub-actions[bot]matching the reminder's own message,/this PR has been inactive for \d+ days\./. Reminders posted before this change use the same text, so they still match.How this was verified
actionlinton the workflow: clean.createCommentstubbed,mainagainst this branch, on the packages PR's cases: a CodeRabbit comment saying "inactive for" and one with the exact reminder text, each on a never-reminded PR, are skipped bymainand reminded by this branch. All other cases are unchanged. On real fix(nvidia-setup): avoid mixed array echo arguments nodewright-packages#154 data the new match reproduces the reminder the live workflow sent on 2026-10-29 and does not repeat it.Checklist
git commit -s -S.