Skip to content

fix(ci): match the inactive PR reminder on its author and message - #927

Merged
lockwobr merged 3 commits into
mainfrom
fix/reminder-match
Oct 30, 2026
Merged

lockwobr merged 3 commits into
mainfrom
fix/reminder-match

Conversation

@lockwobr

@lockwobr lockwobr commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Trivial follow-up to #893 (issue #892), porting NVIDIA/nodewright-packages#176 so the two copies of the workflow stay identical apart from the fork guard.

isReminder treated any bot comment containing "inactive for" as this workflow's reminder, so another bot using that phrase after a PR's last activity would suppress a reminder that was due. It now requires a comment from github-actions[bot] matching the reminder's own message, /this PR has been inactive for \d+ days\./. Reminders posted before this change use the same text, so they still match.

How this was verified

  • actionlint on the workflow: clean.
  • Dry run of the extracted script in Node with createComment stubbed, main against this branch, on the packages PR's cases: a CodeRabbit comment saying "inactive for" and one with the exact reminder text, each on a never-reminded PR, are skipped by main and reminded by this branch. All other cases are unchanged. On real fix(nvidia-setup): avoid mixed array echo arguments nodewright-packages#154 data the new match reproduces the reminder the live workflow sent on 2026-10-29 and does not repeat it.

Checklist

  • I am familiar with the Contributing Guidelines.
  • This PR closes an issue that is assigned to me, or it is a trivial change that needs none.
  • My commits are signed off per the DCO and cryptographically signed: git commit -s -S.
  • If this changes code, I ran the relevant suite locally and recorded the result above.
  • New or existing tests cover these changes. (No test harness exists for workflow scripts; the dry run above stands in.)
  • The documentation is up to date with these changes.
  • If an AI tool wrote a meaningful part of this change, I have said so above, and I can explain and defend every line of it. Written with Claude Code.

Any bot comment containing "inactive for" counted as a reminder, so
another bot's wording could suppress a due one. Match comments from
github-actions[bot] with the reminder's own message, which still
recognises reminders posted before this change.

Follow-up to #893 review feedback.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
@lockwobr
lockwobr requested a review from a team October 29, 2026 20:40
@lockwobr lockwobr self-assigned this Oct 29, 2026
@github-actions github-actions Bot added the component/ci CI workflows, GitHub Actions, and repo tooling label Oct 29, 2026
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 16c844f and c57fea7.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
Walkthrough

The inactive PR reminder detector now requires a commented event from github-actions[bot]. The comment body must match this PR has been inactive for <digits> days.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • NVIDIA/nodewright#893: This PR updates the same reminder detection logic and is described as the subject of follow-up review feedback.

Suggested labels: component/ci

Suggested reviewers: rice-riley

Merge Risk: Minimal · previous review d2e5c

The reminder detector preserves recognition of existing reminders while narrowing matches to the intended workflow-generated comments.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: matching inactive-PR reminders by both author and message.
Description check Passed The description directly explains the workflow change, its motivation, verification steps, and testing limitation.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lockwobr
lockwobr enabled auto-merge (squash) October 30, 2026 21:08
@lockwobr
lockwobr merged commit 3ede793 into main Oct 30, 2026
23 checks passed
@lockwobr
lockwobr deleted the fix/reminder-match branch October 30, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ci CI workflows, GitHub Actions, and repo tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants