Skip to content

fix: use shared gate labels in multi-folder scan #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anatbimblich wants to merge 2 commits into from
Closed

fix: use shared gate labels in multi-folder scan #1507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
406eea9
fix: use shared gate labels in multi-folder scan
anatbimblich Nov 4, 2026
46331f1
Merge branch 'main' into fix-issue-1335-reimplementation
anatbimblich Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions tests/multi-folder-scan.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,25 +1324,34 @@ describe("handleMultiFolderScan - maintenance risk JSON output", () => {
describe("handleMultiFolderScan - maintenance risk terminal render", () => {
it("prints gate-class section headings from the shared labels", async () => {
const { GATE_CLASS_LABELS } = await import("../src/utils/severity.js");
const originalOverrideHygiene = GATE_CLASS_LABELS.overrideHygiene;
const originalMaintenanceRisk = GATE_CLASS_LABELS.maintenanceRisk;
Object.defineProperty(GATE_CLASS_LABELS, "overrideHygiene", { value: "__override_heading__" });
Object.defineProperty(GATE_CLASS_LABELS, "maintenanceRisk", { value: "__maintenance_heading__" });

loadMultiplePackagesMock.mockReturnValue([
{ subfolder: "a", scanInput: makeScanInput() },
]);
detectDM001Mock.mockResolvedValue([
{ ruleId: "DM001", severity: "high", package: { name: "gray-matter", version: "4.0.3" }, drag: [], message: "x" },
]);

await handleMultiFolderScan({
projectRoot: "/project",
batchSize: 100,
options: { ...baseOptions, checkOverrides: true, checkMaintenance: true },
});
try {
await handleMultiFolderScan({
projectRoot: "/project",
batchSize: 100,
options: { ...baseOptions, checkOverrides: true, checkMaintenance: true },
});

const written = stdoutWriteSpy.mock.calls.map(call => String(call[0])).join("");
expect(written).toContain(GATE_CLASS_LABELS.overrideHygiene);
expect(written).toContain(GATE_CLASS_LABELS.maintenanceRisk);
// and none of the hand-typed copies satisfy the sentinels above
expect(written).not.toContain("override hygiene");
expect(written).not.toContain("maintenance risk");
const written = stdoutWriteSpy.mock.calls.map(call => String(call[0])).join("");
expect(written).toContain("__override_heading__");
expect(written).toContain("__maintenance_heading__");
expect(written).not.toContain("override hygiene");
expect(written).not.toContain("maintenance risk");
} finally {
Object.defineProperty(GATE_CLASS_LABELS, "overrideHygiene", { value: originalOverrideHygiene });
Object.defineProperty(GATE_CLASS_LABELS, "maintenanceRisk", { value: originalMaintenanceRisk });
}
});
});

Expand Down
Loading