Repository navigation
Credit the battle pet tutorial quests on win and at level 3 - #1624
Open
icemansparks wants to merge 2 commits into
Open
icemansparks wants to merge 2 commits into
icemansparks wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The battle pet trainer quests Learning the Ropes and Level Up! can never be finished. Their objectives are kill credits for two creatures that retail grants through client spells (127966 on a win, 129584 at level 3), and nothing in this core grants them.
To reproduce: take Learning the Ropes from a battle pet trainer and win a wild pet battle, or take Level Up! and raise a pet to level 3; the objective never ticks.
This credits the first creature when a battle is won and the second when a pet crosses level 3. Fails on main, passes with this change. Got one! is not touched, main already credits it.