Skip to content

Credit the battle pet tutorial quests on win and at level 3 - #1624

Open
icemansparks wants to merge 2 commits into
ProjectSkyfire:mainfrom
icemansparks:upstream/pet-tutorial-credit
Open

icemansparks wants to merge 2 commits into
ProjectSkyfire:mainfrom
icemansparks:upstream/pet-tutorial-credit

Conversation

@icemansparks

Copy link
Copy Markdown
Contributor

The battle pet trainer quests Learning the Ropes and Level Up! can never be finished. Their objectives are kill credits for two creatures that retail grants through client spells (127966 on a win, 129584 at level 3), and nothing in this core grants them.

To reproduce: take Learning the Ropes from a battle pet trainer and win a wild pet battle, or take Level Up! and raise a pet to level 3; the objective never ticks.

This credits the first creature when a battle is won and the second when a pet crosses level 3. Fails on main, passes with this change. Got one! is not touched, main already credits it.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant