Repository navigation
Remove browser dependencies from E2E test cases - #8947
Open
isaacroldan wants to merge 4 commits into
Open
isaacroldan wants to merge 4 commits into
isaacroldan wants to merge 4 commits into
Conversation
isaacroldan
force-pushed
the
codex/improve-cli-release-qa-with
branch
from
October 19, 2026 13:49
f73f22a to
b5a9e37
Compare
isaacroldan
added this pull request to stack #8950
October 19, 2026 13:50
isaacroldan
removed this pull request from stack #8950
October 19, 2026 14:10
isaacroldan
force-pushed
the
codex/improve-cli-release-qa-with
branch
from
October 19, 2026 14:10
b5a9e37 to
dd6ea18
Compare
3 tasks
isaacroldan
added this pull request to stack #8951
October 19, 2026 14:11
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -21,7 +21,6 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
- private jsonOutputFromFlags;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -37,7 +36,6 @@ declare abstract class BaseCommand extends Command {
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
- protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
protected environmentsFilename(): string | undefined;
protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
protected validateNonTTYFlags(flags: FlagOutput): void;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,12 +11,5 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<{
- createdAtRuntime: boolean;
- id: number;
- name: string;
- processing: boolean;
- role: string;
- src?: string;
- }>;
+ create(themeRole?: Role, themeName?: string): Promise<Theme>;
}
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/metafield_definitions_by_owner_type.d.ts@@ -2,14 +2,9 @@ import * as Types from './types.js';
import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core';
export type MetafieldDefinitionsByOwnerTypeQueryVariables = Types.Exact<{
ownerType: Types.MetafieldOwnerType;
- after?: Types.InputMaybe<Types.Scalars['String']['input']>;
}>;
export type MetafieldDefinitionsByOwnerTypeQuery = {
metafieldDefinitions: {
- pageInfo: {
- hasNextPage: boolean;
- endCursor?: string | null;
- };
nodes: {
key: string;
name: string;
|
isaacroldan
force-pushed
the
codex/improve-cli-release-qa-with
branch
from
October 20, 2026 08:32
256a0c2 to
a31b297
Compare
1 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Browser-based app cleanup causes E2E failures unrelated to CLI behavior.
WHAT is this pull request doing?
Use authenticated HTTP for app lookup and deletion, with app identity checks, CSRF protection, and deletion confirmation. After a successful uninstall, retry stale installation-count rejections for up to 15 seconds. Also move malformed-TOML checks to the local suite and remove a terminal-wrapping assertion.
Browsers remain necessary for shared login and legacy bulk cleanup. Remote E2E jobs remain non-blocking in CI.
How to manually test your changes?
With E2E credentials configured, select an uninstalled disposable E2E app. Run
pnpm --filter e2e exec tsx scripts/cleanup-apps.ts --delete --pattern <exact-owned-app-name>and confirm the app is gone from the dashboard.Checklist