Repository navigation
Use fixed stores for CLI E2E tests - #8949
Draft
isaacroldan wants to merge 1 commit into
Draft
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
isaacroldan
added this pull request to stack #8950
October 19, 2026 13:50
isaacroldan
removed this pull request from stack #8950
October 19, 2026 14:10
isaacroldan
force-pushed
the
codex/e2e-persistent-stores
branch
from
October 19, 2026 14:11
5daa401 to
1dcbdb5
Compare
3 tasks
isaacroldan
added this pull request to stack #8951
October 19, 2026 14:11
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -21,7 +21,6 @@ declare abstract class BaseCommand extends Command {
static descriptionWithoutMarkdown(): string | undefined;
static analyticsNameOverride(): string | undefined;
static analyticsStopCommand(): string | undefined;
- private jsonOutputFromFlags;
catch(error: Error & {
skipOclifErrorHandling: boolean;
}): Promise<void>;
@@ -37,7 +36,6 @@ declare abstract class BaseCommand extends Command {
}, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(options?: Input<TFlags, TGlobalFlags, TArgs>, argv?: string[]): Promise<ParserOutput<TFlags, TGlobalFlags, TArgs> & {
argv: string[];
}>;
- protected runWithParsedOutput<T>(flags: FlagOutput, execute: () => T): T;
protected environmentsFilename(): string | undefined;
protected parseEnvironmentFlags<TFlags extends FlagOutput, TGlobalFlags extends FlagOutput, TArgs extends ArgOutput>(environment: JsonMap, options: Input<TFlags, TGlobalFlags, TArgs>, explicitFlags: FlagOutput): Promise<FlagOutput>;
protected validateNonTTYFlags(flags: FlagOutput): void;
packages/cli-kit/dist/public/node/themes/theme-manager.d.ts@@ -11,12 +11,5 @@ export declare abstract class ThemeManager {
findOrCreate(name?: string, role?: Role): Promise<Theme>;
fetch(name?: string, role?: Role): Promise<Theme | undefined>;
generateThemeName(context: string): string;
- create(themeRole?: Role, themeName?: string): Promise<{
- createdAtRuntime: boolean;
- id: number;
- name: string;
- processing: boolean;
- role: string;
- src?: string;
- }>;
+ create(themeRole?: Role, themeName?: string): Promise<Theme>;
}
\ No newline at end of file
packages/cli-kit/dist/cli/api/graphql/admin/generated/metafield_definitions_by_owner_type.d.ts@@ -2,14 +2,9 @@ import * as Types from './types.js';
import { TypedDocumentNode as DocumentNode } from '@graphql-typed-document-node/core';
export type MetafieldDefinitionsByOwnerTypeQueryVariables = Types.Exact<{
ownerType: Types.MetafieldOwnerType;
- after?: Types.InputMaybe<Types.Scalars['String']['input']>;
}>;
export type MetafieldDefinitionsByOwnerTypeQuery = {
metafieldDefinitions: {
- pageInfo: {
- hasNextPage: boolean;
- endCursor?: string | null;
- };
nodes: {
key: string;
name: string;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Creating and deleting a development store for every app test adds provisioning delays and store-quota failures.
WHAT is this pull request doing?
Give each of the seven dev test cases a fixed store from the
E2E_STORESmap, with an eighth store kept as a spare. An optionalE2E_STORE_FQDNoverrides these assignments locally. Playwright handles sharding directly; store allocation, capacity checks, and store-sharing locks are removed. Four workers per shard retain the current CI load.Every test creates a separate app and cleans only that app and preview. Concurrent runs may share stores. App names and cleanup patterns include the run, attempt, and shard. Remote cleanup failures produce warnings without blocking store reuse; failure to stop CLI processes remains an error.
Add a dedicated CLI store creation/deletion lifecycle case to retain provisioning coverage, and fix cleanup links to use numeric app IDs. This layer retains browser app deletion; #8947 replaces it with HTTP cleanup. Store commands are unchanged.
How to manually test your changes?
Set
E2E_STORE_FQDNinpackages/e2e/.envto use a development store accessible to your account, or leave it empty to use the fixed assignments insetup/constants.ts. Review the assignments and cleanup recovery instructions inpackages/e2e/README.md.With two separate app projects, run
pnpm shopify app dev --path <app-path> --store <store.myshopify.com>for each in turn. Confirm both apps can use the store even when the first app remains installed.Validation and remaining limits
33 local E2E tests pass on this layer, including cleanup-failure and store-protection checks. E2E lint and type checks pass. Playwright discovery selects all remote cases exactly once across the two shards without a configured store list. A targeted live store lifecycle check passed during development.
Concurrent use of one store by separate apps is supported by inspection of the backend's app-and-shop session keys; overlapping live E2E runs have not been stress-tested. Full live app-dev coverage remains unverified because the last attempt hit the generated template's unsupported
2025-10API version. Remote E2E jobs remain non-blocking in CI.Checklist