Repository navigation
Bench: retry the heartbeat file on Windows - #34
Open
daniel-frenkel wants to merge 6 commits into
Open
daniel-frenkel wants to merge 6 commits into
daniel-frenkel wants to merge 6 commits into
Conversation
… the change) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ill ends a move) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…redicted) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bench tooling only. No firmware, workflow or release change.
What it does
bench_common.write_heartbeat: when Windows refuses to replace the heartbeat file (another process has it open), it retries every 10 ms for up to 0.5 s. If the replace is still refused it skips that beat and returns False; the next beat tries again. A run of skipped beats reads as stale, which still blocks or stops moves.bench_common.guard_ok: when the read is refused it retries every 10 ms for up to 0.2 s, then reports not OK ("heartbeat file stayed locked").tools/bench/heartbeat_check.pyruns HB1-HB5, each with a sabotage.Checks (
tools/regression-gate/predictions/2026-11-bench-heartbeat-retry.md, registered before the change)Not for merge before the 2.2.0 tag; TP-1 runs from this branch until then.
🤖 Generated with Claude Code