fix(security): throttle failed student password reset answer attempts#324
Open
Isaries wants to merge 1 commit into
Open
fix(security): throttle failed student password reset answer attempts#324Isaries wants to merge 1 commit into
Isaries wants to merge 1 commit into
Conversation
The student password reset compared the security answer in plain text with no attempt limit, so the low-entropy answer could be brute forced to take over any student account. The change endpoint had neither a limit nor a captcha, unlike the teacher flow which locks out after repeated failures. Lock the reset after too many failed answer attempts within a short window, for both the answer check and the password change endpoints, matching the teacher flow. The counter reuses the existing failed password reset verification fields, so no schema change is needed.
Author
|
Paired client change: WISE-Community/WISE-Client#2325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The student password reset compared the security answer in plain text with no limit on attempts. Because these answers are low entropy, an attacker could brute force the answer and take over a student account. This adds throttling that matches the approach the teacher password reset flow already uses.
Changes
Paired change
This is paired with a WISE-Client change (branch
fix/student-reset-throttle) that displays a message for the new throttling response code.Testing
mvnw package).