fix(security): show a message when password reset answers are throttled#2325
Open
Isaries wants to merge 1 commit into
Open
fix(security): show a message when password reset answers are throttled#2325Isaries wants to merge 1 commit into
Isaries wants to merge 1 commit into
Conversation
The server now temporarily blocks the student password reset flow after several incorrect security answers to prevent brute forcing the answer. The security answer step previously ignored any unrecognized response code, so a throttled user saw a blank error and no explanation. Handle the throttling response code in both the security answer and password change steps so the user is told to wait or to ask their teacher.
Author
|
Paired server change: WISE-Community/WISE-API#324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pairs with the WISE-API change that throttles the student password reset flow after several incorrect security answers. The server now returns a throttling response code. The security answer step previously ignored any unrecognized response code, so a throttled user saw a blank error with no explanation.
Changes
Paired change
Paired with the WISE-API change (branch
fix/student-reset-throttle) that adds the throttling.