Skip to content

fix(frontend): check the @types/node version the lockfile resolves #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamAGH merged 1 commit into from
Nov 1, 2026
Merged

fix(frontend): check the @types/node version the lockfile resolves #271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions frontend/scripts/verify-node-version.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,14 @@ if (!gettingStartedGuide.includes(expectedDocumentationVersion)) {
throw new Error(`docs/getting-started.md must name ${expectedDocumentationVersion}`);
}
// Types from a newer Node major type-check APIs this runtime lacks.
const nodeTypesMajor = frontendPackage.devDependencies?.["@types/node"]
?.replace(/^[\^~]/, "")
.split(".")[0];
// The lockfile's resolved version is the truth a range, alias, or dependencies entry resolves to.
const nodeTypesMajor =
frontendLockfile.packages?.["node_modules/@types/node"]?.version?.split(".")[0];
const runtimeMajor = canonicalNodeVersion.split(".")[0];
if (nodeTypesMajor !== undefined && nodeTypesMajor !== runtimeMajor) {
throw new Error(`frontend/package.json @types/node must stay on the Node ${runtimeMajor} major`);
throw new Error(
`frontend @types/node resolves to major ${nodeTypesMajor}; it must stay on the Node ${runtimeMajor} major`,
);
}

console.log(`Node ${canonicalNodeVersion} projections are synchronized.`);
Loading