resources: Align models with upstream Agones structs#25
Open
NAME-ASHWANIYADAV wants to merge 1 commit into
Open
resources: Align models with upstream Agones structs#25NAME-ASHWANIYADAV wants to merge 1 commit into
NAME-ASHWANIYADAV wants to merge 1 commit into
Conversation
Signed-off-by: ashwani yadav <22ashwaniyadav@gmail.com>
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What this PR does
Aligns the
GameServer,Fleet, andFleetAutoscalerTypeScript models with the upstream Agones Go structures. This ensures that the plugin correctly parses and displays all available data from the Kubernetes API.Specific alignments include:
eviction(with correct defaultNever),addresses, andreservedUntilfields.allocationOverflow,priorities,counters, andlists.wasmpolicies and corrected theschedule.activePeriodcron field fromscheduletostartCron.Overview.tsxto includeReservedinSTATE_ORDERand updated the FleetAutoscaler Detail view to correctly reference the fixedstartCronfield.Screenshots / recordings
Test plan
Automated checks
npm cinpm run buildnpm run tscnpm run lintnpm run format -- --checknpm run testManual verification
Manually verified that the UI renders without errors when encountering the newly supported fields, and confirmed that the models successfully map data from the Agones CRDs.
RBAC considerations
N/A - No new Kubernetes permissions are required.
Notes for reviewers
This PR focuses strictly on aligning the type models. Comprehensive unit tests for these resources, along with the necessary Vitest testing infrastructure, are included in a follow-up PR (
fix/test-infra-gameserver) to keep this review focused and atomic.