Repository navigation
Refuse deleting a secret an image names - #26
Merged
Merged
Conversation
An Image holds its registry credential by reference, so the credential it reads with could be deleted out from under it. Adds an Images client and folds it into the DeleteSecret reference check alongside egress rules and subscriptions. Fails closed when IMAGES_GRPC_TARGET is unset, as the other two do.
This was referenced Aug 13, 2026
Four workflow steps each spelled out the buf path list, so adding images/v1 to the Makefile left the image build generating without it and failing to compile. One list now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on agynio/api#190 and pairs with agynio/images#3.
An Image now holds its registry credential by reference, which puts it in the same position as an EgressRule's
injectand a Subscription'ssecret_id: the credential it reads with can be deleted out from under it.DeleteSecretgains the third check.Adds
ImagesClientmirroringllm.goandegress_rules.go, and folds it intoensureSecretUnreferencedso every class of reference is still reported in one error rather than one refusal at a time.Fails closed when
IMAGES_GRPC_TARGETis unset, as the other two do — the umbrella wires it in agynio/platform-charts.