Repository navigation
Conversation
…mestamp An asset can receive several events with the exact same timestamp, and the endpoint assumed the newest timestamp identified a single event. Users hitting the endpoint for such an asset got an unexplained server error instead of the asset details.
steveahnahn
left a comment
There was a problem hiding this comment.
LGTM. The id tie-break is still served by idx_asset_id_timestamp on both Postgres and MySQL, so this is also cheaper than the two-step lookup it replaces.
|
Hello @ColtenOuO - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 19 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Summary
GET /assets/{asset_id}resolves the asset's "last asset event" in two steps: it first computesmax(AssetEvent.timestamp)for the asset, then re-queries the events matching that timestamp with.one_or_none(). Nothing guarantees that timestamp is unique — an asset can be updated by several tasks within the same clock tick, and the timestamp column has no uniqueness constraint. When two or more events tie on the newest timestamp, the second query returns multiple rows and SQLAlchemy raisesMultipleResultsFound, which surfaces to the caller as500 Internal Server Errorinstead of the asset payload.This is the same class of bug fixed for
/ui/assetsin #71047 (that fix broke the tie withmax(id)inside the aggregate query), but the public API endpoint was not covered by it and still carries the original two-step lookup.Changes
airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py: replace themax(timestamp)subquery +.one_or_none()pair with a single ordered query —ORDER BY timestamp DESC, id DESC LIMIT 1— so exactly one event is selected and ties are broken deterministically on the highest id, matching the/ui/assetsbehaviour.airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py: addTestGetAssetEndpoint::test_should_respond_200_with_tied_last_event_timestamps, which creates two events for the same asset with identical timestamps and asserts the endpoint returns200with the higher event id aslast_asset_event. The test returns500without the source change.Was generative AI tooling used to co-author this PR?