Repository navigation
Conversation
23e71af to
7cbb0d8
Compare
Toasters reported only the HTTP status phrase the generated client puts on error.message, so a rejected action surfaced as "Conflict" or "Bad Request" while the reason the API had already sent went unread. ErrorAlert already rendered that field for every shape FastAPI returns it in, so sharing one formatter gives every screen that reports through a toaster the real message.
7cbb0d8 to
ab78989
Compare
|
Hello @ColtenOuO - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 19 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
Sumarry
Error toasters raised by
createErrorToaster()reported only the HTTP status phrase, so a user who hit a rejected action sawConflictorBad Requestinstead of the reason the API had already sent them.getErrorMessage()inerrorHandling.tsreaderror.message, and for the generated client that field never carries the API's own explanation: it comes from the status-code table inopenapi-gen/requests/core/request.ts, which maps every response to a bare phrase. The reason lives inerror.body.detail, which was dropped.ErrorAlertalready knew how to render that field in all three shapes FastAPI returns it in (a plain string, a list of validation errors, an object keyed by field). This extracts that logic into a sharedgetErrorDetail()and has bothErrorAlertandcreateErrorToaster()use it, so every screen that reports errors through a toaster gains the real message.Before / after
Deleting a Dag run that is still running returns:
Conflict.Was generative AI tooling used to co-author this PR?