Skip to content

Show detailed API error messages in UI toasters - #72831

Closed
ColtenOuO wants to merge 1 commit into
apache:mainfrom
ColtenOuO:fix-toaster-show-api-error-detail
Closed

ColtenOuO wants to merge 1 commit into
apache:mainfrom
ColtenOuO:fix-toaster-show-api-error-detail

Conversation

@ColtenOuO

Copy link
Copy Markdown
Contributor

Sumarry

Error toasters raised by createErrorToaster() reported only the HTTP status phrase, so a user who hit a rejected action saw Conflict or Bad Request instead of the reason the API had already sent them.

getErrorMessage() in errorHandling.ts read error.message, and for the generated client that field never carries the API's own explanation: it comes from the status-code table in openapi-gen/requests/core/request.ts, which maps every response to a bare phrase. The reason lives in error.body.detail, which was dropped.

ErrorAlert already knew how to render that field in all three shapes FastAPI returns it in (a plain string, a list of validation errors, an object keyed by field). This extracts that logic into a shared getErrorDetail() and has both ErrorAlert and createErrorToaster() use it, so every screen that reports errors through a toaster gains the real message.

Before / after

Deleting a Dag run that is still running returns:

  • Before: the toaster said Conflict.
image
  • After: the toaster says why the run cannot be deleted.
image
Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 5)

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 9, 2026
@ColtenOuO
ColtenOuO force-pushed the fix-toaster-show-api-error-detail branch from 23e71af to 7cbb0d8 Compare September 9, 2026 18:12
Toasters reported only the HTTP status phrase the generated client puts on
error.message, so a rejected action surfaced as "Conflict" or "Bad Request"
while the reason the API had already sent went unread. ErrorAlert already
rendered that field for every shape FastAPI returns it in, so sharing one
formatter gives every screen that reports through a toaster the real message.
@potiuk

potiuk commented Sep 25, 2026

Copy link
Copy Markdown
Member

Hello @ColtenOuO - thank you for your contributions to Apache Airflow!

The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 19 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:

These pull requests stay open because maintainers are already engaged in them - they count towards your limit:

This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are.

What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or gh pr reopen <PR_NUMBER> --repo apache/airflow. Reopen the ones you are ready to follow through - keep them rebased, respond to review comments and fix failing checks.

While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack.

Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk potiuk closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. closed because of open PR limit Closed as a one-time step of introducing the open pull request limit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants