Repository navigation
Stop the EKS executor concurrency test from starving its own builders - #75197
Merged
vincbeck merged 1 commit intoOct 20, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
pankajastro
force-pushed
the
fix-eks-concurrent-builds-test-timeout
branch
from
October 20, 2026 10:09
e5871aa to
a3090ba
Compare
The watcher thread spun on os.environ.get without yielding, holding the GIL against the client-building threads. The test took about 95 seconds locally and exceeded its 60 second timeout in the lowest-dependencies CI job. Co-Authored-By: Claude <noreply@anthropic.com>
pankajastro
force-pushed
the
fix-eks-concurrent-builds-test-timeout
branch
from
October 20, 2026 10:26
a3090ba to
41c5414
Compare
Contributor
vincbeck
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_concurrent_builds_never_change_sts_regional_endpoints_env_var(added in #74399) runs a watcher thread that pollsos.environwhile 8 workers build EKS clients. The watcher spun without ever yielding, so it held the GIL against the builders. The test took about 95 seconds locally and hit its 60 second timeout in the lowest-dependencies CI job (Low dep tests: providers, amazon), failing it on unrelated PRs. Failing runs:The watcher now sleeps 1 ms between samples. The test takes about 1 second.
Checked locally:
boto3/botocore(1.42.79).AWS_STS_REGIONAL_ENDPOINTSduring a build and a write that is never restored both fail it through theenv_writesassertion, and a write that bypassesos.environ.__setitem__fails it through the sampling assertion (5 of 5 runs).test__client_factory.pypass.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5.5) following the guidelines
🤖 Generated with Claude Code