Skip to content

Stop the EKS executor concurrency test from starving its own builders #75197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Oct 20, 2026
+3 −0
Merged

Stop the EKS executor concurrency test from starving its own builders #75197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions providers/amazon/tests/unit/amazon/aws/executors/eks/test__client_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import signal
import tempfile
import threading
import time
from base64 import b64encode
from concurrent.futures import ThreadPoolExecutor
from pathlib import Path
Expand Down Expand Up @@ -152,6 +153,8 @@ def test_concurrent_builds_never_change_sts_regional_endpoints_env_var(self, moc
def watch():
while building.is_set():
seen.add(os.environ.get("AWS_STS_REGIONAL_ENDPOINTS"))
# A bare spin loop holds the GIL against the builders and can push the test past its timeout.
time.sleep(0.001)

building.set()
watcher = threading.Thread(target=watch)
Expand Down