Repository navigation
fix(dev/release): pin surefire version for Java JAR verification - #4948
Merged
Merged
Conversation
kou
commented
Oct 23, 2026
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.5.4</version> |
Member
Author
There was a problem hiding this comment.
3.5.4 isn't the latest version but I use 3.5.4 here because
Line 105 in 0327758
Member
Author
There was a problem hiding this comment.
Oh, it's 3.5.2. I'll use 3.5.2.
Debian's Maven package patches the default surefire version to 2.17, which doesn't support the JUnit Platform. As a result, no tests in VerifyReleaseCandidateTest were run and the verification passed without checking anything. Pin maven-surefire-plugin to 3.5.2, the same version used by java/, and enable failIfNoTests so that the verification fails if no tests are run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kou
force-pushed
the
fix-verify-java-surefire
branch
from
October 23, 2026 23:54
f724e51 to
850a0b4
Compare
Member
|
Hmm, we should probably fix the verify job to trigger on this subdirectory |
Member
lidavidm
added a commit
that referenced
this pull request
Oct 26, 2026
#4948 didn't trigger relevant pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian's Maven package patches the default surefire version to 2.17, which doesn't support the JUnit Platform. As a result, no tests in VerifyReleaseCandidateTest were run and the verification passed without checking anything.
Pin maven-surefire-plugin to 3.5.2 and enable failIfNoTests so that the verification fails if no tests are run.
Closes #4947.