Repository navigation
fix(rust): return NotFound on driver not found instead of Internal on Windows - #4971
Merged
Merged
Conversation
amoeba
marked this pull request as ready for review
October 27, 2026 22:33
lidavidm
pushed a commit
that referenced
this pull request
Oct 28, 2026
Adds some basic test coverage for loading drivers by name/path. I found these gaps while working on #4971.
lidavidm
approved these changes
Oct 28, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Thanks. Maybe it's worth trying to do the driver manager validation suite...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust driver manager returns an inconsistent error class across platforms. On non-Windows platforms, trying to load a driver that doesn't exist is handled and we return NotFound. On Windows, don't catch a failed load and just pass it upwards which results in an Internal error. I don't think there's any good reason to return different errors for the same behavior across platforms.
There's a TODO about this: https://github.com/apache/arrow-adbc/blob/main/rust/driver_manager/src/search.rs#L527.
This PR syncs the behavior between non-Windows and Windows platforms in the Rust driver manager and adds a regression test in the Javascript bindings. The new behavior is tested by updating the existing
test_load_from_name_missing_drivertest to not only verify we return a non-empty error but that we return a Driver not found error with detail.