[hickey-ai]

Which Issue(s) This PR Fixes

Fixes #11458

Brief Description

Correct the reversed capacity comparison in the byte-array constructor. Valid partial-byte arrays can be reconstructed and cloned, while logical bit lengths beyond the backing storage are rejected. Use a long capacity calculation and retain the existing null/empty/non-positive checks and defensive copying.

Update two tests that encoded the reversed capacity expectations and add one clone regression covering nine bit lengths, retained contents, independent storage and logical bounds. This is separate from the index-bound changes in #10506.

How Did You Test This Change?

• Exact-source utility suite: 28 tests, 3 failing before the fix, all 28 passing after on Java 8 and Java 21.
• Native Java 8/Maven 3.6.3: mvn -B -pl filter -am -Dtest=BitsArrayTest,BloomFilterTest,ExpressionTest,FilterSpiTest,ParserTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false test
• All 110 filter tests passed, with 0 failures/errors/skips; Checkstyle and SpotBugs passed for the reactor code modules. Ancestor modules were compiled and checked, their full unit suites were not selected.
• The published branch Git tree was compared with the tested local tree and is identical.

No live broker or message-loss reproduction is claimed; BloomFilter normally rounds to whole bytes.

AI assistance: OpenAI Codex was used for investigation, implementation and tests; commit messages include tooling provenance.

[RockteMQ-AI]

LGTM. This is a critical bug fix — the original validation was inverted.

Summary

Fixed the backing capacity validation in BitsArray constructor: the comparison direction was reversed, rejecting valid inputs and accepting invalid ones.

Analysis

Original bug:

if (bitLength < bytes.length * Byte.SIZE) {  // WRONG: rejects valid cases
    throw new IllegalArgumentException(...);
}

This rejected valid cases (e.g., 10-bit array backed by 2 bytes) and accepted invalid cases (e.g., 20-bit array backed by 1 byte).

Fix:

if (bitLength > (long) bytes.length * Byte.SIZE) {  // CORRECT
    throw new IllegalArgumentException(...);
}

The fix also adds (long) cast to prevent integer overflow for large byte arrays.

The updated tests correctly verify both valid and invalid cases. The clone test ensures independent storage and partial byte length preservation.

---

Automated review by github-manager-bot