Skip to content

[ISSUE #11458] Fix BitsArray backing capacity validation #11459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hickey-ai wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #11458] Fix BitsArray backing capacity validation #11459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79570e8
[ISSUE #11458] Fix BitsArray backing capacity validation
hickey-ai Oct 20, 2026
d846cdf
[ISSUE #11458] Cover partial-byte cloning and capacity bounds
hickey-ai Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions filter/src/main/java/org/apache/rocketmq/filter/util/BitsArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ private BitsArray(byte[] bytes, int bitLength) {
throw new IllegalArgumentException("Bit is less than 1.");
}

if (bitLength < bytes.length * Byte.SIZE) {
throw new IllegalArgumentException("BitLength is less than bytes.length() * " + Byte.SIZE);
if (bitLength > (long) bytes.length * Byte.SIZE) {
throw new IllegalArgumentException("BitLength is greater than bytes.length() * " + Byte.SIZE);
}

this.bytes = new byte[bytes.length];
Expand Down
34 changes: 30 additions & 4 deletions filter/src/test/java/org/apache/rocketmq/filter/util/BitsArrayTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertThrows;
import static org.junit.Assert.assertTrue;

public class BitsArrayTest {
Expand Down Expand Up @@ -51,10 +52,14 @@ public void testCreateWithBytes() {

@Test
public void testCreateWithBytesAndBitLength() {
byte[] data = new byte[] {(byte) 0xAA};
byte[] data = new byte[] {(byte) 0xAA, (byte) 0x03};
BitsArray bits = BitsArray.create(data, 10);
assertEquals(10, bits.bitLength());
assertEquals(1, bits.byteLength());
assertEquals(2, bits.byteLength());
assertArrayEquals(data, bits.bytes());
assertNotSame(data, bits.bytes());
assertTrue(bits.getBit(9));
assertThrows(IllegalArgumentException.class, () -> bits.getBit(10));
}

@Test(expected = IllegalArgumentException.class)
Expand All @@ -78,8 +83,29 @@ public void testCreateWithZeroBitLength() {
}

@Test(expected = IllegalArgumentException.class)
public void testCreateWithBitLengthLessThanBytes() {
BitsArray.create(new byte[] {0x01, 0x02}, 8);
public void testCreateWithBitLengthGreaterThanBytes() {
BitsArray.create(new byte[] {0x01}, 9);
}

@Test
public void testClonePreservesPartialByteLengthAndIndependentStorage() {
for (int bitLength : new int[] {1, 7, 9, 10, 15, 17, 63, 64, 65}) {
BitsArray original = BitsArray.create(bitLength);
original.setBit(0, true);
original.setBit(bitLength - 1, true);

BitsArray copy = original.clone();

assertEquals(bitLength, copy.bitLength());
assertEquals(original.byteLength(), copy.byteLength());
assertArrayEquals(original.bytes(), copy.bytes());
assertNotSame(original.bytes(), copy.bytes());
assertTrue(copy.getBit(bitLength - 1));
assertThrows(IllegalArgumentException.class, () -> copy.getBit(bitLength));
copy.setBit(0, false);
assertTrue(original.getBit(0));
assertFalse(copy.getBit(0));
}
}

@Test
Expand Down