fix: Protect mem consumption from null deref#4895
Open
lum1n0us wants to merge 1 commit intobytecodealliance:mainfrom
Open
fix: Protect mem consumption from null deref#4895lum1n0us wants to merge 1 commit intobytecodealliance:mainfrom
lum1n0us wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
lum1n0us
commented
Mar 31, 2026
lum1n0us
commented
- add debug assertions to wasm_get_module_inst_mem_consumption
- add debug assertions to aot_get_module_inst_mem_consumption
- nullify memories pointer after free in destruction path
- nullify memories pointer after free in AOT destruction
- docs: add precondition documentation for memory consumption functions
- add debug assertions to wasm_get_module_inst_mem_consumption - add debug assertions to aot_get_module_inst_mem_consumption - nullify memories pointer after free in destruction path - nullify memories pointer after free in AOT destruction - docs: add precondition documentation for memory consumption functions
| if (module_inst->memory_count > 0) { | ||
| memories_deinstantiate(module_inst, module_inst->memories, | ||
| module_inst->memory_count); | ||
| module_inst->memories = NULL; |
Contributor
There was a problem hiding this comment.
I don't think it's worth setting NULL here? Given the fact that this module inst is about to be destroyed anyway? It will create an inconsistency with other data members, like L3455
| } | ||
| } | ||
| wasm_runtime_free(module_inst->memories); | ||
| module_inst->memories = NULL; |
Contributor
There was a problem hiding this comment.
I don't think it's worth setting NULL here? Given the fact that the module instance will be destroyed later anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.