Skip to content

fix: bump rust-dashcore to c88264e7 for Android SPV file-lock fix#4014

Merged
QuantumExplorer merged 1 commit into
v4.1-devfrom
fix/bump-rust-dashcore-android-spv
Jul 5, 2026
Merged

fix: bump rust-dashcore to c88264e7 for Android SPV file-lock fix#4014
QuantumExplorer merged 1 commit into
v4.1-devfrom
fix/bump-rust-dashcore-android-spv

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jul 5, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Bumps the rust-dashcore pin so the workspace picks up the Android SPV file‑lock fix and two other dash-spv fixes that landed on dev since the current pin.

The headline motivation is dashpay/rust-dashcore#840: on target_os = "android", std::fs::File::try_lock() is a compile‑time Unsupported stub (Android isn't in std's flock cfg list), so dash-spv's lock‑file guard failed fatally and Core/SPV could never start in the Android SDK. rust-dashcore #841 makes the lock degrade gracefully; this bump brings it into the platform. Without it, the KotlinExampleApp (#3999) Core layer is dead on device.

What was done?

Updated the single shared rust-dashcore rev in the workspace [workspace.dependencies] (all 8 crates: dashcore, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dash-network-seeds, dashcore-rpc) plus the matching Cargo.lock entries:

afcff1566c81abb0a9cf64b99b0ee675169fddfc  →  c88264e77f0af05c7a7f45efe72c87572e80a67a

dev is a clean fast‑forward (4 commits, 0 behind) over the old pin. The four commits pulled in:

Cargo.lock moved only the rust-dashcore‑sourced crates to the new rev; 92 other dependencies are unchanged.

How Has This Been Tested?

  • cargo check -p platform-wallet (the primary dash-spv consumer) against the new rev — green; it re-compiled dash-spv / key-wallet / dpp / drive / dash-sdk / platform-wallet against c88264e7 with no errors (Finished dev profile … in 1m00s). Confirms no API drift from the 4 upstream commits.
  • No source changes; this is a dependency‑pin bump only. Full builds run in CI.

On the underlying fix: the Android failure this unblocks was reproduced and root‑caused on an API‑35 arm64 emulator against the old pin — starting Core sync threw SPV error: Write failed: Failed to acquire lock: try_lock() not supported, which is exactly the path rust-dashcore#841 makes non‑fatal. Re‑verifying Core SPV start on device with the new pin (rebuild the rs-unified-sdk-jni .so) is the natural follow‑up.

Breaking Changes

None. dash-spv/key-wallet are the client/SPV + wallet layer, not consensus code — this is not a consensus‑breaking change. No public API changes on the platform side (the dash-spv deltas are internal fixes; #827's config‑field rename is not referenced by this repo).

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated several workspace dependencies to a newer upstream revision, which may bring compatibility improvements and general maintenance updates.

Move the shared rust-dashcore pin from afcff156 to c88264e7 (dev, a clean
4-commit fast-forward) to pick up dash-spv #841, which makes the advisory
lock-file guard degrade gracefully when std file locking is unsupported —
the case on target_os=android, where Core/SPV otherwise fails to start
("try_lock() not supported"). Also includes dash-spv #835 (filter-sync
restart stall) and #827 (internal peer-config field rename; not referenced
here). Cargo.lock updates only the rust-dashcore-sourced crates.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 5, 2026
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2922577a-0918-420d-bb79-0eb68d828d88

📥 Commits

Reviewing files that changed from the base of the PR and between 050bab1 and 7e71dda.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

Updates the git revision pin for eight rust-dashcore workspace dependencies (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) in Cargo.toml to a newer commit.

Changes

Dependency Revision Update

Layer / File(s) Summary
Workspace dependency rev bump
Cargo.toml
Eight rust-dashcore git dependencies updated from rev afcff1566c81abb0a9cf64b99b0ee675169fddfc to c88264e77f0af05c7a7f45efe72c87572e80a67a.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • dashpay/platform#3757: Updates the same workspace rev values for the same set of rust-dashcore crates to a different revision.
  • dashpay/platform#3973: Also bumps the same rust-dashcore workspace git-rev pins for the same crate set.
  • dashpay/platform#3976: Another rust-dashcore workspace rev bump for the same dependencies, later superseded revision.

Suggested labels: ready for final review

Suggested reviewers: lklimek

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: bumping rust-dashcore to pick up the Android SPV file-lock fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bump-rust-dashcore-android-spv

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit 7e71dda)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Source: reviewers = Claude Opus and Codex gpt-5.5 for general/ffi-engineer; verifier = Claude Opus; specialists = ffi-engineer.

Pure dependency-pin bump of workspace rust-dashcore crates from afcff156 to c88264e7. Both agents independently verified the four upstream commits are non-consensus SPV/wallet changes with no FFI or API surface impact on this repo. No findings to flag.

@QuantumExplorer QuantumExplorer merged commit 0877460 into v4.1-dev Jul 5, 2026
19 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/bump-rust-dashcore-android-spv branch July 5, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants