Fix panic on empty --json flag value#5498
Open
simonfaltum wants to merge 2 commits into
Open
Conversation
JsonFlag.Set indexed v[0] without a length check, so an empty value (for example from an unset shell variable) crashed the CLI with an index out of range panic. Return a validation error instead. Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
|
Commit: 74c1e4c
22 interesting tests: 15 SKIP, 7 KNOWN
Top 29 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found during a full-repo review of the CLI. Passing an empty value to
--json(for exampledatabricks jobs create --json=, or--json "$VAR"where the shell variable is unset) crashed the CLI with an index out of range panic instead of a usable error message.Changes
Before, an empty
--jsonvalue panicked; now it fails with a clean validation error.JsonFlag.Setinlibs/flags/json_flag.goindexedv[0]to check for the@fileprefix without first checking the length. It now rejects empty input up front, and cobra surfaces it asinvalid argument "" for "--json" flag: expected inline JSON or @path/to/file, got an empty string.Test plan
TestJsonFlagEmptyValuecovering the empty value case (panics without the fix, passes with it)go test ./libs/flagspasses./task fmt-q,./task lint-q, and./task checkspassThis pull request and its description were written by Isaac.