Skip to content

Fix panic on empty --json flag value #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonfaltum wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix panic on empty --json flag value #5498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398fda6
Fix panic on empty --json flag value
simonfaltum Jun 9, 2026
74c1e4c
Remove redundant comments
simonfaltum Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libs/flags/json_flag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package flags

import (
"encoding/json"
"errors"
"fmt"
"os"
"reflect"
Expand All @@ -23,6 +24,9 @@ func (j *JsonFlag) String() string {

// TODO: Command.MarkFlagFilename()
func (j *JsonFlag) Set(v string) error {
if v == "" {
return errors.New("expected inline JSON or @path/to/file, got an empty string")
}
// Load request from file if it starts with '@' (like curl).
if v[0] != '@' {
j.raw = []byte(v)
Expand Down
7 changes: 7 additions & 0 deletions libs/flags/json_flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ func TestJsonFlagEmpty(t *testing.T) {
assert.Nil(t, request)
}

func TestJsonFlagEmptyValue(t *testing.T) {
var body JsonFlag

err := body.Set("")
assert.EqualError(t, err, "expected inline JSON or @path/to/file, got an empty string")
}

func TestJsonFlagInline(t *testing.T) {
var body JsonFlag

Expand Down
Loading