Repository navigation
Fix agenda builder revalidating in an endless loop - #21
Merged
Merged
Conversation
The post-save revalidate effect depended on `revalidator`, which is a new object on every state change. Each revalidation finishing returned it to idle and re-ran the effect, so the page fetched its .data endlessly from the moment it rendered until the tab crashed. Only revalidate on the saving -> idle transition. Co-Authored-By: Claude <noreply@octopus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the agenda builder (
/admin/voting/agenda/:runId) fetches its.dataendpoint several times a second from the moment it renders, until the tab crashes.The effect that revalidates once the save queue drains depended on
revalidator, which React Router recreates on every state change. Each revalidation finishing put it back toidlewith a new identity, re-running the effect and kicking off the next one. Thestate === 'idle'guard only blocked re-entry during a fetch, not after.Fix: track the previous
isSavingin a ref and only revalidate on the saving → idle transition. The 10s poll is unaffected.🤖 Generated with Claude. 💁♂️ Reviewed and refined by Andrew.