Repository navigation
Update dependency @lexical/link to v0.52.0 - #1195
renovate[bot] wants to merge 1 commit into
Conversation
Deploying mouseterm with
|
| Latest commit: |
4edf020
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22ab92a6.mouseterm.pages.dev |
| Branch Preview URL: | https://renovate-lexical-link-0-x.mouseterm.pages.dev |
dormouse-bot
left a comment
dormouse-bot
left a comment
There was a problem hiding this comment.
This bump installs a second copy of Lexical, and the viewer's link patch moves onto the copy the editor doesn't use. It should not merge on its own.
@mdxeditor/editor@4.3.3 declares "@lexical/link": "^0.48.0" and "lexical": "^0.48.0". For a 0.x caret, that means <0.49, so mdxeditor keeps resolving @lexical/link@0.48.0. The lockfile now also adds @lexical/link@0.52.0 with its own lexical@0.52.0, @lexical/extension, html, selection, utils, and a11y, while dor-tools-builtin's direct lexical stays pinned at 0.48.0.
markdown-link-url.ts imports LinkNode from @lexical/link only to overwrite LinkNode.prototype.sanitizeUrl. After this change, that import resolves to the 0.52 class. The LinkNodes the editor creates come from mdxeditor's 0.48 copy, so the override never runs on them. The regression documented in docs/specs/dor-tools-builtin.rationale.md → "Lexical 0.48 formats a bare Markdown filename such as b.md as https://b.md" comes back. The scheme sanitizer still holds because 0.48's own sanitizeUrl runs, so this is not a safety hole. test/markdown-links.test.mjs calls sanitizeLinkUrl directly, so it can't catch the split.
Build & Test is red at "Dependency disclosure is current" for the same reason: lexical and @lexical/* now list both 0.48.0 and 0.52.0. Regenerating the snapshot would turn CI green but would still ship the split, so I haven't pushed that.
@lexical/link and lexical need to move with mdxeditor's Lexical range, not on their own schedule. That calls for closing this PR and adding a .github/renovate.json rule, either allowedVersions or disabling lexical/@lexical/** with a description pointing at mdxeditor. That rule is a policy choice, so I've left it to a maintainer.
This branch is waiting to be deployed
2 participants
This PR contains the following updates:
0.48.0→0.52.0Release Notes
facebook/lexical (@lexical/link)
v0.52.0Compare Source
v0.51.0Compare Source
v0.50.0Compare Source
v0.49.0Compare Source
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
* * * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.