feat: deterministic channel release PR titles#107
Merged
Conversation
The release PR title/body and merge commit previously showed registry-derived prerelease counters, which could drift between PR creation and publish (and degraded to an arbitrary alphabetical lead package + '(+N more)' in multi-package cycles). Now they show only what's derivable from committed state: targets with a wildcard counter (1.2.0-rc.x), and a package count when several packages ship. The PR check comment and channel version output use the same wildcard; status and ci plan keep live registry-derived counters.
|
This PR targets the
|
theoephraim
added a commit
that referenced
this pull request
Jun 12, 2026
`pull_request_target` executes the workflow file from the **default branch**, not the PR's base branch. So the check-local/check-published dogfood split that landed on `next` (72c8ed1) has never actually run — PRs targeting `next` are still checked by main's old single-job workflow running published bumpy 1.13.2. Observed on [#107](#107) (a next-targeted PR): the run executed the `bumpy-check` job (main's workflow), and old bumpy — with no channel awareness — diffed against `main` instead of `GITHUB_BASE_REF`, so the comment listed the already-shipped `.bumpy/next/prerelease-channels.md` as a mysterious "(empty — no release)" bump file, with a stable `1.13.3` plan instead of the channel prerelease plan. This copies `next`'s `bumpy-check.yaml` to main verbatim (so the eventual promotion merge is clean): - **check-published** — fork PRs: published bumpy, never executes PR code. - **check-local** — internal PRs: builds and runs the PR head's own bumpy, so channel-aware comments work on next-targeted PRs immediately, no published release required. `release.yaml` is intentionally not included — `push` workflows run from the pushed branch, so `next`'s copy already works (the rc.0 publish proved it). Workflow-only change; no bump file needed.
theoephraim
added a commit
that referenced
this pull request
Jun 13, 2026
Promotes the `next` prerelease channel to stable. This merge carries the cycle's accumulated bump files (in `.bumpy/next/`) into main — versions never diverged, so the diff is the feature work plus file moves. On merge, main's release workflow will open the ordinary stable version PR: `@varlock/bumpy` → **1.14.0**, with a consolidated changelog entry built from the cycle's bump files. The `@next` dist-tag has shipped `1.14.0-rc.0` and `1.14.0-rc.1` through this cycle. What's in the cycle: - **Prerelease channels** ([#104](#104)) — branch-based prerelease lines; versions derived at publish time, never committed. - **Deterministic channel release PR titles** ([#107](#107)) — wildcard `rc.x` counters in PR titles/bodies/commits so they can't drift from the registry; package count for multi-package cycles. Validated live on [#109](#109). - **Docs** ([#106](#106)) — environment deployment-branch allowances for channel branches with trusted publishing. --------- Co-authored-by: bumpy 🐸 <bumpy.bot@varlock.dev> Co-authored-by: bumpy-bot <276066384+bumpy-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel release PR titles previously showed registry-derived prerelease counters, which could be out of sync with what actually publishes (the registry is re-queried at publish time and wins). They also degraded poorly in multi-package cycles: an arbitrary alphabetical lead package plus
(+N more).Titles, PR bodies, and merge commit messages now only claim what's derivable from committed state:
1.2.0-rc.x; the target comes from bump files (deterministic), the.xis assigned from the registry at publish. The title can no longer drift, by construction.🐸 Versioned release (next): 4 packagesinstead of an arbitrary lead +(+N more). Single-package cycles keepname@1.2.0-rc.x.forDisplayfetch (and its offline-rc.?fallback) is gone from the release PR path; one less network dependency and failure mode.statusandci plankeep live registry-derived counters (.?when offline) since they're interactive/live output.versionoutput now use.xtoo (they never queried the registry;.?previously implied a failed lookup rather than "assigned later").Docs updated where they described the title as "advisory narrative; registry wins" — the new story is simpler: the title only shows deterministic state.
All 292 tests pass, including new coverage for
channelDisplayPlan(wildcard mapping + unpublishable-package filtering).