docs: prune learnings section and tighten create-pr skill#25453
Open
dvdksn wants to merge 3 commits into
Open
Conversation
Drop the optional Learnings section and the PR learnings scanner reference. The self-learning loop it fed was never used. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Document the optional @netlify entry-path stanza for focused PRs and how to add deploy-preview deep links derived from the PR number. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Guard against running on the default branch (main/master) - Use git status --porcelain to catch staged/unstaged changes, not just unstaged ones - Handle the case where origin is upstream docker/docs by pushing to a separate fork remote, and derive FORK_OWNER from that remote - Note the docs:/scope title prefix convention Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
❌ Deploy Preview for docsdocker failed. Why did it fail? →
|
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
One high-severity issue found in the new content introduced by this PR.
| learnings that would help future contributors avoid the same issue. Do not | ||
| include things already documented in AGENTS.md or STYLE.md. | ||
| ```bash | ||
| gh pr edit <pr-number> --repo docker/docs --body "..." |
Contributor
There was a problem hiding this comment.
[HIGH] gh pr edit --body overwrites the entire PR body, not appends to it
The new "Optional: Preview links" section instructs contributors to run:
gh pr edit <pr-number> --repo docker/docs --body "..."However, gh pr edit --body replaces the entire PR description with the provided string — it does not append. A contributor following this literally would erase their Summary, Closes line, @netlify stanza, and any other body content, replacing it all with only the preview links.
Consider either:
- Showing how to fetch and append — e.g., retrieve the current body with
gh pr view <pr-number> --json body -q .body, append the links, then pass the full result to--body. - Directing contributors to add the links manually via the GitHub web UI instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused Learnings/reflections section from the create-pr skill (the self-learning loop it fed was never used), adds optional guidance for Netlify deploy-preview entry paths and deep links on focused PRs, and tightens the branch/remote handling (default-branch guard,
git status --porcelainclean-tree check, origin-vs-fork fallback, and adocs:title-prefix note).Generated by Claude Code