Repository navigation
Remove _REDIRECT; serializer relies on _arg_spec only - #319
Merged
Merged
Conversation
rozyczko
added
[scope] maintenance
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 292-remove-objbase #319 +/- ##
=====================================================
Coverage ? 94.12%
=====================================================
Files ? 52
Lines ? 4139
Branches ? 0
=====================================================
Hits ? 3896
Misses ? 243
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Since the original PR was approved, I will be merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly rebased branch, without extra artifacts from merging 292-remove-objbase
Look at #314 to find more info
Removed the
_REDIRECTmechanism fromDescriptorBaseandParameter, and updated the_convert_to_dictmethod inSerializerBaseto use only_arg_specfor determining which attributes to serialize.