Repository navigation
Conversation
evancohen
marked this pull request as ready for review
September 11, 2026 00:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep native hotword detection in the snowboy npm package so Sonus does not need to embed it. Companion Sonus PR: evancohen/sonus#109.
Changes:
Validation: all Linux x64 package jobs passed on Node 14.21.3, 18, 20, and 22: https://github.com/evancohen/snowboy/actions/runs/34547751252 . Each job builds and packs the package, performs a normal consumer install from the tarball, initializes the native detector, and processes silent audio. Package contents were checked for the runtime JS, type declarations, header/source, engine library and models.
The tested tarball is available as the snowboy-1.4.0-rc.0 workflow artifact on that run. CI never publishes. npm release requires approval; prerelease should use a non-latest tag. macOS and Raspberry Pi hardware remain unverified, and real microphone/recognition-quality testing is outside this CI coverage.
Install verification is inline in the GitHub Actions workflow. No test directory or test scripts are included in the npm package.