Repository navigation
Conversation
… fixes Adapt JavaScript behavior from sdetweil/sonus f01d0b1 without importing embedded native sources or binaries.
This was referenced Sep 11, 2026
evancohen
marked this pull request as ready for review
September 11, 2026 00:47
evancohen
marked this pull request as draft
September 11, 2026 00:49
evancohen
marked this pull request as ready for review
September 11, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep native hotword detection in the separate snowboy package and harden Sonus's recording/recognition lifecycle before merging the behavior changes from Sam's fork.
Depends on evancohen/snowboy#2 (unpublished 1.4.0-rc.0). This PR is based directly on upstream master; no native sources, libraries, or embedded Snowboy history are imported. It replaces #108.
Package separation:
Correctness fixes found during review:
Validation on the final commit: all Node 14.21.3, 20, and 22 jobs passed on Linux x64: https://github.com/evancohen/sonus/actions/runs/34548575527 .
Remaining validation: no physical microphone/arecord device or live Google Speech session was available. These CI checks do not establish recognition quality or Raspberry Pi/macOS hardware compatibility. A device-level recording/rollover/pause/resume and conversational-turn check is still appropriate before release.
Release sequence: publish the approved Snowboy prerelease first, then Sonus. Do not release against the currently nonexistent registry version. CI temporarily builds the pinned Snowboy candidate locally. Nothing has been published, and smart-mirror's dependency remains unchanged.