Skip to content

fix(security): prevent shell/JSON injection via PR title in Chat notification workflow #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XananasX7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): prevent shell/JSON injection via PR title in Chat notification workflow #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 42 additions & 74 deletions .github/workflows/pr_notification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,83 +18,51 @@ jobs:
- name: Google Chat Notification
shell: bash
env:
# All untrusted values are passed via env vars and encoded with jq
# to prevent shell injection and JSON injection attacks.
TITLE: ${{ github.event.pull_request.title }}
LABELS: ${{ join(github.event.pull_request.labels.*.name, ', ') }}
GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
GITHUB_EVENT_PULL_REQUEST_USER_LOGIN: ${{ github.event.pull_request.user.login }}
GITHUB_EVENT_PULL_REQUEST_HTML_URL: ${{ github.event.pull_request.html_url }}
REPO: ${{ github.event.pull_request.head.repo.full_name }}
CREATOR: ${{ github.event.pull_request.user.login }}
PR_URL: ${{ github.event.pull_request.html_url }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_STATE: ${{ github.event.pull_request.state }}
ASSIGNEES: ${{ join(github.event.pull_request.assignees.*.login, ', ') }}
REVIEWERS: ${{ join(github.event.pull_request.requested_reviewers.*.login, ', ') }}
run: |
curl --location --request POST '${{ secrets.WEBHOOK_URL }}' \
--header 'Content-Type: application/json' \
--data-raw '{
"cards": [
{
# Build JSON safely with jq to handle special characters in PR title/labels
PAYLOAD=$(jq -n \
--arg title "$TITLE" \
--arg labels "$LABELS" \
--arg repo "$REPO" \
--arg creator "$CREATOR" \
--arg url "$PR_URL" \
--arg prnum "$PR_NUMBER" \
--arg state "$PR_STATE" \
--arg assignees "$ASSIGNEES" \
--arg reviewers "$REVIEWERS" \
'{
"cards": [{
"header": {
"title": "Pull request notification",
"subtitle": "Pull request: #${{ github.event.pull_request.number }}"
"subtitle": ("Pull request: #" + $prnum)
},
"sections": [
{
"widgets": [
{
"keyValue": {
"topLabel": "Repo",
"content": "${GITHUB_EVENT_PULL_REQUEST_HEAD_REPO_FULL_NAME}"
}
},
{
"keyValue": {
"topLabel": "Title",
"content": "'"$TITLE"'"
}
},
{
"keyValue": {
"topLabel": "Creator",
"content": "${GITHUB_EVENT_PULL_REQUEST_USER_LOGIN}"
}
},
{
"keyValue": {
"topLabel": "State",
"content": "${{ github.event.pull_request.state }}"
}
},
{
"keyValue": {
"topLabel": "Assignees",
"content": "- ${{ join(github.event.pull_request.assignees.*.login, ', ') }}"
}
},
{
"keyValue": {
"topLabel": "Reviewers",
"content": "- ${{ join(github.event.pull_request.requested_reviewers.*.login, ', ') }}"
}
},
{
"keyValue": {
"topLabel": "Labels",
"content": "- '"$LABELS"'"
}
},
{
"buttons": [
{
"textButton": {
"text": "Open Pull Request",
"onClick": {
"openLink": {
"url": "${GITHUB_EVENT_PULL_REQUEST_HTML_URL}"
}
}
}
}
]
}
]
}
]
}
]
}'
"sections": [{
"widgets": [
{"keyValue": {"topLabel": "Repo", "content": $repo}},
{"keyValue": {"topLabel": "Title", "content": $title}},
{"keyValue": {"topLabel": "Creator", "content": $creator}},
{"keyValue": {"topLabel": "State", "content": $state}},
{"keyValue": {"topLabel": "Assignees", "content": $assignees}},
{"keyValue": {"topLabel": "Reviewers", "content": $reviewers}},
{"keyValue": {"topLabel": "Labels", "content": $labels}},
{"buttons": [{"textButton": {"text": "Open Pull Request",
"onClick": {"openLink": {"url": $url}}}}]}
]
}]
}]
}')

curl --location --request POST '${{ secrets.WEBHOOK_URL }}' \
--header 'Content-Type: application/json' \
--data-raw "$PAYLOAD"
Loading