Skip to content

build: update from node 22 to node 24 - #2822

Merged
helio-frota merged 1 commit into
guacsec:mainfrom
helio-frota:TC-6702
Oct 28, 2026
Merged

helio-frota merged 1 commit into
guacsec:mainfrom
helio-frota:TC-6702

Conversation

@helio-frota

@helio-frota helio-frota commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Upgrade the project’s Node.js baseline from version 22 to version 24 across development, build, CI, and documentation workflows.

Enhancements:

  • Update development, documentation, and CI environments to require Node.js 24.

Build:

  • Use Node.js 24 when building binaries and setting up the console environment.

CI:

  • Run documentation checks and builds with Node.js 24.

Documentation:

  • Update source-build, UI, and end-to-end testing prerequisites to reference Node.js 24.

@sourcery-ai

sourcery-ai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The pull request updates all identified Node.js runtime configuration points from version 22 to version 24, covering the reusable console setup action and documentation-related CI jobs while preserving existing setup and caching behavior.

File-Level Changes

Change Details Files
Upgrade CI and local console setup to use Node.js 24.
  • Change the shared console setup action from Node.js 22 to Node.js 24 while retaining npm dependency caching.
  • Run documentation checks and builds on Node.js 24 in the CI and documentation workflows.
.github/actions/setup-console/action.yaml
.github/workflows/ci.yaml
.github/workflows/docs.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@helio-frota
helio-frota requested a review from ctron October 28, 2026 14:19

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@helio-frota

Copy link
Copy Markdown
Contributor Author

thanks @desmax74 🚀

@helio-frota
helio-frota enabled auto-merge October 28, 2026 14:32
@ctron

ctron commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Wouldn't we need some updated to the release workflow as well?

@helio-frota

Copy link
Copy Markdown
Contributor Author

I found nothing when searching about node version on release.yaml 🤔 🤷‍♂️

@gildub gildub added the backport release/0.7.z Backport (0.7.z) label Oct 28, 2026
@ctron

ctron commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

As it's failing in the vendoring step: https://github.com/guacsec/trustify/actions/runs/40687430872/job/122813832899

@helio-frota

Copy link
Copy Markdown
Contributor Author

yeah thanks ... I think this will probably work.. I updated some missing READMEs...

pushd vendor/trustify-ui/res
npm ci --ignore-scripts
popd

this happens on build-binary.yaml which uses uses actions/checkout@v7 which defaults to node24

[[[ which is weird because this is not inheriting other gh-actions I changed 🤔 ]]]

@ctron

ctron commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Ok, then we'll merge and find out.

@helio-frota

helio-frota commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

@ctron that is related to the ubuntu version apparently (instead of actions/checkout@v7) ... I got this from google search -- file updated 👍

On the standard GitHub Actions runner image for Ubuntu 24.04 (ubuntu-24.04 or ubuntu-latest), the default pre-installed version of Node.js on the system PATH is 22.23.3

[update] yeah : https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#language-and-runtime

@ctron

ctron commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

so, we need to update the node version in that job too?

@helio-frota

helio-frota commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

so, we need to update the node version in that job too?

sounds weird to me as well but yes because this workflow is focused on rust - uses: ./.github/actions/setup-rust and then it grabs nodejs default from the ubuntu-24.04.

@helio-frota
helio-frota added this pull request to the merge queue Oct 28, 2026
Merged via the queue into guacsec:main with commit 56b3611 Oct 28, 2026
11 checks passed
@helio-frota
helio-frota deleted the TC-6702 branch October 28, 2026 17:06
@github-project-automation github-project-automation Bot moved this to Done in Trustify Oct 28, 2026
@trustify-ci-bot

Copy link
Copy Markdown

Backport failed for release/0.7.z, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/0.7.z
git worktree add -d .worktree/backport-2822-to-release/0.7.z origin/release/0.7.z
cd .worktree/backport-2822-to-release/0.7.z
git switch --create backport-2822-to-release/0.7.z
git cherry-pick -x 56b3611589d4d272af0587889a7605353d2e35b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/0.7.z Backport (0.7.z)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants