🌱 Fuzz conversion for v1beta1 <-> v1beta2#3119
🌱 Fuzz conversion for v1beta1 <-> v1beta2#3119lentzi90 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/L
lentzi90
force-pushed
the
lentzi90/fuzz-conversion-v1beta1-v1beta2
branch
from
8efb07a to
a6e0c39
Compare
Replace the deprecated gofuzz library with randfill, updating all fuzzer function signatures and method calls accordingly. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/fuzz-conversion-v1beta1-v1beta2
branch
from
a6e0c39 to
daf2a25
Compare
lentzi90
left a comment
lentzi90
left a comment
There was a problem hiding this comment.
/hold cancel
/approve
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
| // * Constrain the output in ways which are validated by the API server | ||
| // * Constrain fields that are not preserved during v1beta2 <-> v1beta1 round-trip conversion | ||
| // * Add additional test coverage where it is not generated by the default fuzzer. | ||
| func InfraV1Beta2FuzzerFuncs() []any { |
There was a problem hiding this comment.
similar to the other one, most of the funcs here are identical copies of the ones in InfraV1FuzzerFuncs. Since slices.Concat merges both lists, the duplicates in InfraV1FuzzerFuncs end up as dead code (last registration wins).
Could this just contain the funcs that are actually new (the OpenStackCluster/OpenStackMachine/OpenStackMachineTemplate/FailureDomain OpenStackClusterStatus normalizers)?
There was a problem hiding this comment.
This made me realize a mistake. The point here was to have different API versions for each function, but now we have the same everywhere. I'll fix this. We will have "duplication" in a way but it will be correct then with v1beta1 for the v1beta1 fuzzing and v1beta2 for the v1beta2 fuzzing
There was a problem hiding this comment.
Now I think this is correct. We have separate fuzzers for v1beta1 and v1beta2, so they are no longer identical and won't overwrite each other.
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Good points @bnallapeta ! I sort of just assumed there would be differences, but in reality a lot of it is still the same. I'll clean it up! |
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
lentzi90
force-pushed
the
lentzi90/fuzz-conversion-v1beta1-v1beta2
branch
from
daf2a25 to
6d3ec0f
Compare
k8s-ci-robot
removed
the
lgtm
|
/hold |
|
Ok we are good, no conflict 👍 |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bnallapeta, lentzi90, nikParasyr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@lentzi90: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
What this PR does / why we need it:
function signatures and method calls accordingly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3011
Special notes for your reviewer:
TODOs:
/hold