Repository navigation
fix: replace Android and Apple template placeholders in nitrogen init - #1986
Merged
Merged
Conversation
#1972 renamed the nitro.json keys and also changed the names init.ts passes to replaceTemplate to `android.namespace`, `android.cxxLibName` and `apple.moduleName`. The template still uses `$$androidNamespace$$`, `$$androidCxxLibName$$` and `$$appleModuleName$$`, so new libraries kept those placeholders in the podspec name, the Kotlin package path and file contents. Go back to the template's names. The init workflow now fails if any file name or file content in the generated library still contains `$$`. Also make the HybridObject JSDoc example import `Apple`, which it uses, instead of `iOS`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1972 renamed the nitro.json keys and also changed the names
init.tspasses toreplaceTemplate. The template still uses$$androidNamespace$$,$$androidCxxLibName$$and$$appleModuleName$$, sonitrogen initleft them in the podspec name, the Kotlin package path and several files. This goes back to the template's names.CI didn't catch it because the init workflow never looked at the result. It now fails if any file name or file content in the generated library still contains
$$.Note:
nitrogen initclonespackages/templatefrom thev1branch on GitHub, so this workflow tests the PR'sinit.tsagainst the template onv1, not against template changes in the PR.Also fixes the
HybridObjectJSDoc example to importAppleinstead ofiOS.🤖 Generated with Claude Code