Skip to content

fix: replace Android and Apple template placeholders in nitrogen init #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrousavy merged 1 commit into from
Oct 23, 2026
Merged

fix: replace Android and Apple template placeholders in nitrogen init #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/run-nitrogen-init.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,15 @@ jobs:
- name: Run nitrogen init outside the checkout
working-directory: ${{ runner.temp }}
run: bun run --bun nitrogen init react-native-math

- name: Check that all template placeholders were replaced
working-directory: ${{ runner.temp }}/react-native-math
run: |
if find . -name '*$$*' | grep .; then
echo "::error::File names above still contain \$\$ template placeholders"
exit 1
fi
if grep -rnIF '$$' .; then
echo "::error::File contents above still contain \$\$ template placeholders"
exit 1
fi
2 changes: 1 addition & 1 deletion packages/nitro-core/js/src/HybridObject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ declare abstract class HybridObject {
* @example
* ```ts
* // Image.nitro.ts
* import { iOS, type HybridObject } from 'nitro-core'
* import { Apple, type HybridObject } from 'nitro-core'
*
* export * from '#nitro/Image'
*
Expand Down
6 changes: 3 additions & 3 deletions packages/nitrogen/src/init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ export async function initNewNitroModule(baseDirectory: string, moduleName: stri
}

await replaceTemplate(modulePath, `cxxNamespace`, cxxNamespace)
await replaceTemplate(modulePath, `android.namespace`, cxxNamespace)
await replaceTemplate(modulePath, `android.cxxLibName`, camelCaseName)
await replaceTemplate(modulePath, `apple.moduleName`, camelCaseName)
await replaceTemplate(modulePath, `androidNamespace`, cxxNamespace)
await replaceTemplate(modulePath, `androidCxxLibName`, camelCaseName)
await replaceTemplate(modulePath, `appleModuleName`, camelCaseName)
await replaceTemplate(modulePath, `packageName`, moduleName)
await replaceTemplate(modulePath, `packageDescription`, moduleName)
await replaceTemplate(modulePath, `nitroVersion`, NITROGEN_VERSION)
Expand Down
Loading