Repository navigation
Support list configuration values via JSON arrays (5.x backport of #27) - #32
Merged
Merged
Conversation
…#29) Configuration options which expect a list of values are now supported by JSON arrays in environment variables. Values that are not a JSON array or object are used literally, as before. The decode avoids JsonException for PHP 7.2.
mbrodala
approved these changes
Oct 16, 2026
|
@snake14 @mbrodala On behalf of the Wikimedia Foundation, thank you very much for the quick turnaround! |
snake14
enabled auto-merge (squash)
October 18, 2026 20:11
AltamashShaikh
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #27 and #29 to 5.x: environment variables holding a JSON array are now used as list values, so settings such as
trusted_hostscan be set from the environment. JSON objects are decoded into keyed arrays; any other value is used literally, as before.The decode uses plain
json_decode()rather thanJSON_THROW_ON_ERROR/JsonException, which 5.x's PHP 7.2 floor doesn't have; the behaviour is the same.Issue No
Fixes #9 on 5.x (backport of #27 and #29)
Steps to Replicate the Issue
MATOMO_GENERAL_TRUSTED_HOSTS=["192.168.1.1","192.168.2.1"]Checklist