Repository navigation
Fix the Redis Cluster backend failing to parse on PHP 7.2 and 7.3 - #354
Merged
Merged
Conversation
snake14
enabled auto-merge (squash)
October 20, 2026 20:59
snake14
added a commit
that referenced
this pull request
Oct 20, 2026
…e the plugin [ignore_release]
…d port mismatch reports its message
snake14
added a commit
that referenced
this pull request
Oct 21, 2026
…elease] (#355) * Move the 5.x-dev checks onto the shared Plugins CI umbrella [ignore_release] * Carry #354's PHP 7.2 parse fix for RedisCluster so PHPStan can analyse the plugin [ignore_release] * Port 6.x-dev's PHPStan fixes so the analysis passes on 5.x-dev [ignore_release] Suppresses the remaining findings where the ext-redis stubs or Matomo 5.0's docblocks are narrower than the code's real contract.
AltamashShaikh
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since 5.1.0, using the Redis Cluster backend on PHP 7.2 or 7.3 fails with a parse error, because
Queue/Backend/RedisCluster.phpbuilds its host list with an arrow function, which needs PHP 7.4. Matomo 5 still supports PHP 7.2.5, so this replaces it with an ordinary closure. Other backends never load that file and are unaffected.Issue No
No GitHub issue. Found by the umbrella CI's PHPStan run at PHP 7.2 on the 5.x-dev migration branch.
Steps to Replicate the Issue
php -l Queue/Backend/RedisCluster.php(or configure QueuedTracking to use Redis Cluster).syntax error, unexpected ':', expecting ',' or ')'on line 308.Checklist