Repository navigation
fix: don't reject a binding call when a listener throws during resolve - #2010
Open
Yury Semikhatsky (yury-s) wants to merge 4 commits into
Open
Yury Semikhatsky (yury-s) wants to merge 4 commits into
Yury Semikhatsky (yury-s) wants to merge 4 commits into
Conversation
…inding calls Fixes: microsoft#2009
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
October 19, 2026 20:04
Yury Semikhatsky (yury-s)
changed the title
Pavel Feldman (pavelfeldman)
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BindingCall.callsentresolveinside the binding'stry. An exception thrown by an event listener while waiting for the reply was treated as the binding's failure, and therejectsent to the already resolved and disposed binding call failed withTargetClosedError, which replaced the listener's exception.trynow covers only invoking the binding, and theresolve/rejectreply is sent after it, so only failures of the binding function lead toreject.Fixes #2009