Skip to content

fix: don't reject a binding call when a listener throws during resolve #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 4 commits into from
Oct 20, 2026
Merged

fix: don't reject a binding call when a listener throws during resolve #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce9f819
fix: report listener exceptions instead of TargetClosedError during b…
yury-s Oct 19, 2026
9e45729
fix: wait for the resolve reply and reject only when the reply fails
yury-s Oct 19, 2026
9dbeda5
fix: send resolve outside of the binding's try block
yury-s Oct 19, 2026
7a63d6b
chore: send a single reply after invoking the binding
yury-s Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions playwright/src/main/java/com/microsoft/playwright/impl/BindingCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,27 +62,30 @@ String name() {
}

void call(BindingCallback binding) {
String method;
JsonObject params = new JsonObject();
try {
Frame frame = connection.getExistingObject(initializer.getAsJsonObject("frame").get("guid").getAsString());
BindingCallback.Source source = new SourceImpl(frame);
List<Object> args = new ArrayList<>();
if (initializer.has("handle")) {
JSHandle handle = connection.getExistingObject(initializer.getAsJsonObject("handle").get("guid").getAsString());
args.add(handle);
} else {
for (JsonElement arg : initializer.getAsJsonArray("args")) {
args.add(deserialize(gson().fromJson(arg, SerializedValue.class)));
}
}
Object result = binding.call(source, args.toArray());

JsonObject params = new JsonObject();
params.add("result", gson().toJsonTree(serializeArgument(result)));
sendMessage("resolve", params, NO_TIMEOUT);
params.add("result", gson().toJsonTree(serializeArgument(invoke(binding))));
method = "resolve";
} catch (RuntimeException exception) {
JsonObject params = new JsonObject();
params.add("error", gson().toJsonTree(serializeError(exception)));
sendMessage("reject", params, NO_TIMEOUT);
method = "reject";
}
sendMessage(method, params, NO_TIMEOUT);
}

private Object invoke(BindingCallback binding) {
Frame frame = connection.getExistingObject(initializer.getAsJsonObject("frame").get("guid").getAsString());
BindingCallback.Source source = new SourceImpl(frame);
List<Object> args = new ArrayList<>();
if (initializer.has("handle")) {
JSHandle handle = connection.getExistingObject(initializer.getAsJsonObject("handle").get("guid").getAsString());
args.add(handle);
} else {
for (JsonElement arg : initializer.getAsJsonArray("args")) {
args.add(deserialize(gson().fromJson(arg, SerializedValue.class)));
}
}
return binding.call(source, args.toArray());
}
}
8 changes: 8 additions & 0 deletions playwright/src/test/java/com/microsoft/playwright/TestBrowserContextExposeFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ void exposeBindingShouldWork() {
assertEquals(page, bindingSource[0].page());
assertEquals(page.mainFrame(), bindingSource[0].frame());
assertEquals(11, result);

// https://github.com/microsoft/playwright-java/issues/2009
page.onConsoleMessage(message -> {
throw new IllegalStateException("failure in console listener");
});
IllegalStateException e = assertThrows(IllegalStateException.class,
() -> page.evaluate("() => { add(1, 2); console.log('after add'); }"));
assertEquals("failure in console listener", e.getMessage());
}

@Test
Expand Down
Loading