Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe mobile menu component is restructured to prioritise account and status information at the top. The update introduces an account section with status buttons for npm CLI and Atmosphere that trigger corresponding modals. Avatar handling is added with fallback icons and user information display. The navigation structure is reorganised with a consolidated flow: account/status area, divider, navigation block with app navigation and connected-user links, followed by informational links. UI dividers separate sections throughout. Existing route-change close and keyboard handling behaviours are maintained with updated focus trap and scroll lock logic. Possibly related PRs
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| :to="{ name: 'about' }" | ||
| class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200" | ||
| @click="closeMenu" | ||
| <!-- Account section --> |
There was a problem hiding this comment.
Remove structural template comments that don’t explain logic.
The added section/divider comments are purely structural and don’t clarify non-obvious behaviour. Please drop them (or replace with semantic wrappers if needed).
🧹 Suggested cleanup (apply similarly to other section labels)
- <!-- Account section -->
<div class="px-2 py-2">
@@
- <!-- npm CLI connection status (only show if connected) -->
<button
@@
- <!-- Divider -->
- <div class="mx-4 my-2 border-t border-border" />
+ <div class="mx-4 my-2 border-t border-border" />As per coding guidelines, “Add comments only to explain complex logic or non-obvious implementations”.
Also applies to: 110-110, 135-135, 159-159, 173-173, 176-176, 178-178, 198-198, 220-220, 223-223, 244-244, 247-247
Before
after