Skip to content

fix: reorder Mobile Menu #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Feb 8, 2026
Merged

fix: reorder Mobile Menu #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
192 changes: 99 additions & 93 deletions app/components/Header/MobileMenu.client.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,28 +99,84 @@ onUnmounted(deactivate)
</button>
</div>

<!-- Navigation links -->
<div class="flex-1 overflow-y-auto overscroll-contain py-2">
<!-- Main navigation -->
<div class="px-2 py-2">
<NuxtLink
:to="{ name: 'about' }"
class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"
@click="closeMenu"
<!-- Account section -->
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove structural template comments that don’t explain logic.

The added section/divider comments are purely structural and don’t clarify non-obvious behaviour. Please drop them (or replace with semantic wrappers if needed).

🧹 Suggested cleanup (apply similarly to other section labels) 
-            <!-- Account section -->
             <div class="px-2 py-2">
@@
-              <!-- npm CLI connection status (only show if connected) -->
               <button
@@
-              <!-- Divider -->
-              <div class="mx-4 my-2 border-t border-border" />
+              <div class="mx-4 my-2 border-t border-border" />

As per coding guidelines, “Add comments only to explain complex logic or non-obvious implementations”.

Also applies to: 110-110, 135-135, 159-159, 173-173, 176-176, 178-178, 198-198, 220-220, 223-223, 244-244, 247-247

<div class="px-2 py-2">
<span
class="px-3 py-2 block font-mono text-xs text-fg-subtle uppercase tracking-wider"
>
{{ $t('account_menu.account') }}
</span>

<!-- npm CLI connection status (only show if connected) -->
<button
v-if="isConnected && npmUser"
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowConnector"
>
<img
v-if="npmAvatar"
:src="npmAvatar"
:alt="npmUser"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon:information w-5 h-5 text-fg-muted" aria-hidden="true" />
{{ $t('footer.about') }}
</NuxtLink>
<span class="i-carbon-terminal w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">~{{ npmUser }}</span>
<span class="w-2 h-2 rounded-full bg-green-500" aria-hidden="true" />
</button>

<NuxtLink
:to="{ name: 'privacy' }"
class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"
@click="closeMenu"
<!-- Atmosphere connection status -->
<button
v-if="atprotoUser"
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowAuth"
>
<img
v-if="atprotoUser.avatar"
:src="atprotoUser.avatar"
:alt="atprotoUser.handle"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon:security w-5 h-5 text-fg-muted" aria-hidden="true" />
{{ $t('privacy_policy.title') }}
</NuxtLink>
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1 truncate">@{{ atprotoUser.handle }}</span>
</button>

<!-- Connect Atmosphere button (show if not connected) -->
<button
v-else
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowAuth"
>
<span class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">{{ $t('account_menu.connect_atmosphere') }}</span>
</button>
</div>

<!-- Divider -->
<div class="mx-4 my-2 border-t border-border" />

<!-- Navigation links -->
<div class="flex-1 overflow-y-auto overscroll-contain py-2">
<!-- App navigation -->
<div class="px-2 py-2">
<NuxtLink
:to="{ name: 'compare' }"
class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"
Expand Down Expand Up @@ -164,7 +220,31 @@ onUnmounted(deactivate)
<!-- Divider -->
<div class="mx-4 my-2 border-t border-border" />

<!-- External links (from footer) -->
<!-- Informational links -->
<div class="px-2 py-2">
<NuxtLink
:to="{ name: 'about' }"
class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"
@click="closeMenu"
>
<span class="i-carbon:information w-5 h-5 text-fg-muted" aria-hidden="true" />
{{ $t('footer.about') }}
</NuxtLink>

<NuxtLink
:to="{ name: 'privacy' }"
class="flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200"
@click="closeMenu"
>
<span class="i-carbon:security w-5 h-5 text-fg-muted" aria-hidden="true" />
{{ $t('privacy_policy.title') }}
</NuxtLink>
</div>

<!-- Divider -->
<div class="mx-4 my-2 border-t border-border" />

<!-- External links -->
<div class="px-2 py-2">
<span class="px-3 py-2 font-mono text-xs text-fg-subtle uppercase tracking-wider">
{{ $t('nav.links') }}
Expand Down Expand Up @@ -227,80 +307,6 @@ onUnmounted(deactivate)
</a>
</div>
</div>

<!-- Divider -->
<div class="mx-4 my-2 border-t border-border" />

<!-- Account section -->
<div class="px-2 py-2">
<span
class="px-3 py-2 block font-mono text-xs text-fg-subtle uppercase tracking-wider"
>
{{ $t('account_menu.account') }}
</span>

<!-- npm CLI connection status (only show if connected) -->
<button
v-if="isConnected && npmUser"
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowConnector"
>
<img
v-if="npmAvatar"
:src="npmAvatar"
:alt="npmUser"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-terminal w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">~{{ npmUser }}</span>
<span class="w-2 h-2 rounded-full bg-green-500" aria-hidden="true" />
</button>

<!-- Atmosphere connection status -->
<button
v-if="atprotoUser"
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowAuth"
>
<img
v-if="atprotoUser.avatar"
:src="atprotoUser.avatar"
:alt="atprotoUser.handle"
width="20"
height="20"
class="w-5 h-5 rounded-full object-cover"
/>
<span
v-else
class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center"
>
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1 truncate">@{{ atprotoUser.handle }}</span>
</button>

<!-- Connect Atmosphere button (show if not connected) -->
<button
v-else
type="button"
class="w-full flex items-center gap-3 px-3 py-3 rounded-md font-mono text-sm text-fg hover:bg-bg-subtle transition-colors duration-200 text-start"
@click="handleShowAuth"
>
<span class="w-5 h-5 rounded-full bg-bg-muted flex items-center justify-center">
<span class="i-carbon-cloud w-3 h-3 text-fg-muted" aria-hidden="true" />
</span>
<span class="flex-1">{{ $t('account_menu.connect_atmosphere') }}</span>
</button>
</div>
</nav>
</Transition>
</div>
Expand Down
Loading